fix notification removed when not found #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a notification is closed, prior to timouting, from $rootScope (e.g. from handleClose), then the timeout closes the wrong notification. This is because notification is by the timeouting removed completely from list and the `.indexOf` returns `-1`, which removes last notification.
vkrizan
force-pushed
the
notification-timeout-remove
branch
from
6565686 to
a47d4b2
Compare
|
LGTM |
1 similar comment
|
LGTM |
jeff-phillips-18
added a commit
to jeff-phillips-18/manageiq-ui-service
that referenced
this pull request
Sep 15, 2016
Specifically looking for: Fix specificity on setting collapsed items width for vertical nav: Adds specificity to vertical navigations settings to set the width for collapsed items to only effect those in vertical navigation. patternfly/patternfly#454 Fix to hide badges on the primary nav menu in collapse mode. patternfly/patternfly#449 Fixes an issue where if a notification is removed while the toast notification is still displayed, the wrong toast notification could get removed. patternfly/angular-patternfly#311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a notification is closed, prior to timouting, from $rootScope (e.g.
from handleClose), then the timeout closes the wrong notification. This is because
notification is by the timeouting removed completely from list and the
.indexOfreturns-1, which removes last notification.There is a possibility that if same notification (with same data) is created between handleClose and timeout close, then it would be closed earlier by the first notification's timeout. Better solution would be to track timeouts and remove them with a notification removal.