Fix for duplicate "None" default values - Related to BZ1428133 #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the latest update, without this change, ManageIQ/manageiq#14240 would produce some oddities in the UI such as potential double "None"/"Choose" values, radio buttons having a "None" option when the user could simply just not pick something, and the sample fields would have doubles as well. Note that everything should still work fine without the UI changes, but it might be very confusing for the user seeing multiple blank values that do the same thing. |
https://bugzilla.redhat.com/show_bug.cgi?id=1428133 Continue to prepend 'none' option for radio buttons while editing the field, because it should still be a default value option, but we do not want to actually display a radio button with a "None" option, they can simply leave it un-checked
|
Checked commit eclarizio@1962209 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/helpers/application_helper/dialogs_spec.rb
|
|
LGTM |
This was referenced Mar 10, 2017
|
Backported to Euwe via ManageIQ/manageiq#14259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the need to prepend 'none' option to values as it is done in model now.
It's not a strictly necessary counterpart for ManageIQ/manageiq#14240, but without it, you would see double "None"/"Choose" values when editing the dialog field.Related to https://bugzilla.redhat.com/show_bug.cgi?id=1428133.
/cc @gmcculloug
@miq-bot add_label bug, euwe/yes