Fix for broken specs in ApplicationHelper::Dialogs #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some specs started breaking on the EUWE backport of ManageIQ/manageiq#14240 and that's because the model logic was changed to include 'none' or 'choose' now instead of the view needing to do it. There was a helper that was missed, and I think the original classic UI PR didn't have the test failure because the model change wasn't merged yet.
This should fix that by relying on the model to provide 'none' values instead of helper trying to do it. It removes some unnecessary logic in the helper and cleans up the tests a little bit as well.
https://bugzilla.redhat.com/show_bug.cgi?id=1428133
Note this does not need to be backported because I found it on the EUWE backport and made the necessary changes there already and am just forwarding it here.
@h-kataria You merged the earlier related classic UI component PR for the above mentioned PRs, so I'm assigning you here as well, please re-assign if this isn't correct!
/cc @gmcculloug
@miq-bot assign @h-kataria