Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken specs in ApplicationHelper::Dialogs #645

Merged
merged 2 commits into from Mar 10, 2017

Conversation

eclarizio
Copy link
Member

@eclarizio eclarizio commented Mar 10, 2017

Some specs started breaking on the EUWE backport of ManageIQ/manageiq#14240 and that's because the model logic was changed to include 'none' or 'choose' now instead of the view needing to do it. There was a helper that was missed, and I think the original classic UI PR didn't have the test failure because the model change wasn't merged yet.

This should fix that by relying on the model to provide 'none' values instead of helper trying to do it. It removes some unnecessary logic in the helper and cleans up the tests a little bit as well.

https://bugzilla.redhat.com/show_bug.cgi?id=1428133

Note this does not need to be backported because I found it on the EUWE backport and made the necessary changes there already and am just forwarding it here.

@h-kataria You merged the earlier related classic UI component PR for the above mentioned PRs, so I'm assigning you here as well, please re-assign if this isn't correct!
/cc @gmcculloug

@miq-bot assign @h-kataria

@eclarizio eclarizio changed the title Rely on model to provide 'none' values instead of helper trying to do it Fix for broken specs in ApplicationHelper::Dialogs Mar 10, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 10, 2017

Checked commits eclarizio/manageiq-ui-classic@00d3031~...966e0cd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 6 offenses detected

spec/services/ansible_tower_job_template_dialog_service_spec.rb

spec/services/orchestration_template_dialog_service_spec.rb

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in UI, works fine 👍

@martinpovolny martinpovolny merged commit 4206379 into ManageIQ:master Mar 10, 2017
@martinpovolny martinpovolny added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants