Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

An error icon can show on a successful migration in the plan details list view #1046

Closed
mturley opened this issue Oct 8, 2019 · 0 comments · Fixed by #1049
Closed

An error icon can show on a successful migration in the plan details list view #1046

mturley opened this issue Oct 8, 2019 · 0 comments · Fixed by #1049
Assignees
Labels
bug bz Issues filed by QE or having a BZ UI Issues and PRs related only to the UI

Comments

@mturley
Copy link
Contributor

mturley commented Oct 8, 2019

This issue is coming up with the latest version of ManageIQ, because of this code:

taskDetails.completedSuccessfully =
    (task.options.progress && task.options.progress.current_description === 'Virtual machine migrated') ||
    (task.options.progress && task.options.progress.current_description === 'Mark source as migrated');

On a list item in the plan request details list, if the task is complete and its current_description is not one of those two magic values, there will be an error icon on the left of that list item. We need to instead check task.state === 'finished' && task.status === 'Ok', which we already use for determining a successful migration elsewhere in the code (we should just reuse the taskCompletedSuccessfully helper at the top of that same file)

This bug can be reproduced using the database dump named status-message-issues from my collection.

Related to BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1759062

@mturley mturley added bug bugzilla needed UI Issues and PRs related only to the UI labels Oct 8, 2019
@mturley mturley self-assigned this Oct 8, 2019
@mturley mturley added bz Issues filed by QE or having a BZ and removed bugzilla needed labels Oct 8, 2019
mzazrivec added a commit that referenced this issue Oct 11, 2019
[#1046] Fix logic for determining if a migration task is completed successfully
simaishi pushed a commit that referenced this issue Feb 21, 2020
[#1046] Fix logic for determining if a migration task is completed successfully

(cherry picked from commit 158e431)

https://bugzilla.redhat.com/show_bug.cgi?id=1789433
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug bz Issues filed by QE or having a BZ UI Issues and PRs related only to the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant