Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error icon can show on a successful migration in the plan details list view #1046

Closed
mturley opened this issue Oct 8, 2019 · 0 comments · Fixed by #1049

Comments

@mturley
Copy link
Contributor

commented Oct 8, 2019

This issue is coming up with the latest version of ManageIQ, because of this code:

taskDetails.completedSuccessfully =
    (task.options.progress && task.options.progress.current_description === 'Virtual machine migrated') ||
    (task.options.progress && task.options.progress.current_description === 'Mark source as migrated');

On a list item in the plan request details list, if the task is complete and its current_description is not one of those two magic values, there will be an error icon on the left of that list item. We need to instead check task.state === 'finished' && task.status === 'Ok', which we already use for determining a successful migration elsewhere in the code (we should just reuse the taskCompletedSuccessfully helper at the top of that same file)

This bug can be reproduced using the database dump named status-message-issues from my collection.

Related to BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1759062

@mturley mturley self-assigned this Oct 8, 2019
@mturley mturley added this to Backlog in v2v UI via automation Oct 8, 2019
@mturley mturley added bz and removed bugzilla needed labels Oct 8, 2019
@mturley mturley moved this from Backlog to To do in v2v UI Oct 8, 2019
v2v UI automation moved this from To do to Done Oct 11, 2019
mzazrivec added a commit that referenced this issue Oct 11, 2019
[#1046] Fix logic for determining if a migration task is completed successfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v2v UI
  
Done
1 participant
You can’t perform that action at this time.