Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

[BZ#1775998] Inaccurate message is displayed in "Conversion Hosts" page while there is only one provider #1072

Closed
mturley opened this issue Nov 26, 2019 · 3 comments · Fixed by #1086
Assignees
Labels
bug bz Issues filed by QE or having a BZ ivanchuk/yes needs-design v1.3

Comments

@mturley
Copy link
Contributor

mturley commented Nov 26, 2019

https://bugzilla.redhat.com/show_bug.cgi?id=1775998

Description of problem:
The "Missing Providers" message displayed is not accurate, in case of VMware -> RHV migration

Version-Release number of selected component (if applicable):
5.11.1.0

How reproducible:
100%

Steps to Reproduce:
Using fresh CFME:
1. Add RHV provider
2. Go to "Migration Settings" -> "Conversion Hosts"

Actual results:
Can't  add conversion hosts due missing providers:
"There are no providers available from which to configure a conversion host. You must configure a target provider before configuring conversion hosts"

Once adding VMware provider -> there is the option to set RHV conversion hosts

Expected results:
The message should be that there is no Source provider
OR to allow to set conversion host while only the RHV provider is configured.

It looks like the issue here is that for the conversion hosts page we reuse the "has sufficient providers" check we already had on plans/mappings pages, which checks that you have both VMWare and one of either RHV or OSP.

@vconzola from a UX perspective, which fix would you prefer?

  • Change the message so it also mentions configuring a source provider
  • Change the behavior so you don't need a VMware provider to get to the conversion hosts page
@mturley mturley added bug bz Issues filed by QE or having a BZ ivanchuk/yes labels Nov 26, 2019
@mturley mturley self-assigned this Nov 26, 2019
@mturley mturley added the v1.3 label Dec 18, 2019
@mturley
Copy link
Contributor Author

mturley commented Jan 6, 2020

@vconzola do you remember if we decided to change the messaging here or change the behavior?

@vconzola
Copy link

vconzola commented Jan 6, 2020

@mturley Sorry this fell thru the cracks. Seems like changing the behavior is the way to go. If user has a RHV provider configured and doesn't need a VMware provider there's no reason to alert them to an issue that doesn't exist.

@mturley
Copy link
Contributor Author

mturley commented Jan 6, 2020

Ok, sounds good. Will see if I can get this into my batch of changes for Monday.

mzazrivec added a commit that referenced this issue Jan 10, 2020
…heck

[#1072] [BZ#1775998] Fix logic for providers check on Conversion Hosts Settings page
simaishi pushed a commit that referenced this issue Feb 21, 2020
…heck

[#1072] [BZ#1775998] Fix logic for providers check on Conversion Hosts Settings page

(cherry picked from commit 5b4ee3b)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1790540
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug bz Issues filed by QE or having a BZ ivanchuk/yes needs-design v1.3
Projects
None yet
2 participants