This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Remove CPU throttling field from Settings due to backend bug #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits mturley/manageiq-v2v@3f382e1~...f1b2cf1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Some comments on commits mturley/manageiq-v2v@3f382e1~...f1b2cf1 app/javascript/react/screens/App/Settings/screens/GeneralSettings/GeneralSettings.js
|
mzazrivec
approved these changes
Sep 10, 2019
|
@fdupont-redhat it sounds to me from watching BugZilla like this will not be needed, so I'll close it. If we do end up needing to remove this part of the UI we can reopen this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on @fdupont-redhat to see whether we really need to merge this, but here it is in case we need an emergency backport here.