Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPU throttling field from Settings due to backend bug #1029

Closed
wants to merge 2 commits into from

Conversation

@mturley
Copy link
Contributor

commented Sep 9, 2019

Waiting on @fdupont-redhat to see whether we really need to merge this, but here it is in case we need an emergency backport here.

@mturley mturley requested a review from mzazrivec Sep 9, 2019

@mturley mturley added the bug label Sep 9, 2019

@miq-bot

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Checked commits mturley/manageiq-v2v@3f382e1~...f1b2cf1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Some comments on commits mturley/manageiq-v2v@3f382e1~...f1b2cf1

app/javascript/react/screens/App/Settings/screens/GeneralSettings/GeneralSettings.js

  • 💣 💥 🔥 🚒 - 117 - Detected cfme
@mturley

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@fdupont-redhat it sounds to me from watching BugZilla like this will not be needed, so I'll close it. If we do end up needing to remove this part of the UI we can reopen this PR.

@mturley mturley closed this Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.