Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work-around AdBlock #127

Merged
merged 2 commits into from Jun 30, 2014
Merged

Work-around AdBlock #127

merged 2 commits into from Jun 30, 2014

Conversation

garrett
Copy link
Contributor

@garrett garrett commented Jun 30, 2014

AdBlock Plus is a bit to aggressive when matching things that might be construed as ads. It thinks the links on the page to various social media sites and the entire subfooter are ads. They're not, obviously... so we have to do a little dance of changing the classnames as to not trigger the blocking.

garrett added a commit that referenced this pull request Jun 30, 2014
@garrett garrett merged commit 562f91c into master Jun 30, 2014
@garrett garrett deleted the work-around-adblock branch June 30, 2014 08:26
@garrett
Copy link
Contributor Author

garrett commented Jun 30, 2014

For reference, here are some links to the adblock + social icons issue:

As we're not actually using the icons for sharing icons (but as link to the ManageIQ presence on the various sites) it's really a bug in AdBlock. It was even more severe, in that AdBlock nuked our links to the forum and Q&A site.

Thankfully, I was able to work-around this and the site should work as intended now.

BTW: Perhaps I should run an older version of the site locally and report the issues via this link:
https://adblockplus.org/en/getting_started#false-positives

@garrett
Copy link
Contributor Author

garrett commented Jun 30, 2014

The culprit was specifically "Fanboy's Social Blocking List".

@garrett
Copy link
Contributor Author

garrett commented Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant