Enable code climate engines #11750
Merged
Enable code climate engines #11750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a follow up, I think I also want us to add the code-climate coverage tool. Their coverage tool can only handle one suite, but if we have the coverage for even just vmdb, I'd be happy. |
|
Checked commits jrafanie/manageiq@2ef4e09~...53c8349 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
https://github.com/ManageIQ/guides/blob/46f5a1f2d796b512666d9d21e92bfebf3e700599/.rubocop.yml This is needed because codeclimate doesn't support inherit_from with URLs in their container environments (for security): See: codeclimate/codeclimate#480 From: codeclimate/codeclimate-rubocop#71
Use languages or engines, not both, so remove the language section. Disabled: * brakeman (slow) * bundler-audit (requires Gemfile.lock) * csslint (try later) * eslint (still failing) * fixme (try later) * markdownlint (try later) Enabled: * duplication * rubocop
jrafanie
force-pushed
the
enable_code_climate_engines
branch
3 times, most recently
from
706e76e
to
cef62e8
Compare
Let's also include ones you might see when running codeclimate CLI: tmp, .git, etc. Note, according to [1], you need to exclude folders like this: ``` exclude_paths: - "tests/" - "spec/" - "**/vendor/" ``` (without the trailing * after the slash) [1] https://docs.codeclimate.com/docs/excluding-files-and-folders
We'll inherit from the new .rubocop_base.yml.
Note, to get a list of cops:
rubocop --show-cops | grep -E "^[a-zA-Z]"
jrafanie
force-pushed
the
enable_code_climate_engines
branch
from
cef62e8
to
b96b494
Compare
line, method, module, class length ABC and perceived complexity(we're already using cyclomatic)
jrafanie
changed the title
|
Great work @jrafanie |
carbonin
added a commit
to carbonin/miq_bot
that referenced
this pull request
Oct 11, 2016
This was added in ManageIQ/manageiq#11750 so that we could avoid inheriting from a remote repo as it is not supported by code climate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable the new (as of 2015) code climate engines
What this PR does:
.rubocop_base.ymlsince code climate doesn't support inheriting from a remote file.rubocop_base.ymland sorts themWhat this PR does NOT do: