Fix typo in auth_key_pair_cloud route #12031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're in a %w(...) so the comma is not needed. This was added in 3580a50. **Before**: $ bin/rake routes |grep "auth_key_pair_cloud\/tag_edit_form_field_changed" GET /auth_key_pair_cloud/tag_edit_form_field_changed,(/:id)(.:format) auth_key_pair_cloud#tag_edit_form_field_changed, POST /auth_key_pair_cloud/tag_edit_form_field_changed(/:id)(.:format) auth_key_pair_cloud#tag_edit_form_field_changed **After**: $ bin/rake routes |grep "auth_key_pair_cloud\/tag_edit_form_field_changed" GET /auth_key_pair_cloud/tag_edit_form_field_changed(/:id)(.:format) auth_key_pair_cloud#tag_edit_form_field_changed POST /auth_key_pair_cloud/tag_edit_form_field_changed(/:id)(.:format) auth_key_pair_cloud#tag_edit_form_field_changed
|
Checked commit jrafanie@df4c6de with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@jrafanie This is totally A-OK! 👍 |
|
Thanks @AparnaKarve |
chessbyte
pushed a commit
that referenced
this pull request
Oct 19, 2016
Fix typo in auth_key_pair_cloud route (cherry picked from commit 909fcc7)
|
Euwe Backport details: $ git log -1
commit 3031aac5a323ee4fc4de176dc99087a25df3f3f8
Author: Brandon Dunne <brandondunne@hotmail.com>
Date: Tue Oct 18 13:36:39 2016 -0400
Merge pull request #12031 from jrafanie/fix_route_typo
Fix typo in auth_key_pair_cloud route
(cherry picked from commit 909fcc7cd677449d5c6dcc2281353923a15ccf3a) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're in a %w(...) so the comma is not needed.
This was added in 3580a50.
Before:
After:
Seen with the code climate browser extension:
@AparnaKarve Please review. I think this needs euwe since #9466 is in euwe