Convert cloud key pair form to angular #9466
Conversation
|
/cc @martinpovolny |
|
@dgutride Thanks for the PR and the quick turnaround! |
| # REST call for provider choices | ||
| def ems_form_choices | ||
| assert_privileges("auth_key_pair_cloud_new") | ||
| ems_choices = [] |
|
@martinpovolny - I think I've addressed all of your comments (including using rubymine to clean up the double-quotes/single-quote/colon property inconsistencies in the haml). |
|
@dgutride Can you squash the last 2 Rubocop related commits? |
| "required" => "", | ||
| "pf-select" => true) | ||
| :javascript | ||
| miqInitSelectPicker(); |
There was a problem hiding this comment.
@dgutride You can remove this JS method and instead use the directive selectpicker-for-select-tag for the select_tag
|
If possible (without rocking the boat too much) ;), can you squash these 2 commits 760a257b18705c17d6194d4a8cd51b32b8ad699f and 4630ba37d3e27769d8caccff5ff18b1fc338f559 (since the second one is more of an 'undo' action) |
| @@ -200,6 +105,7 @@ def key_pair_save | |||
| :model => ui_lookup(:table => 'auth_key_pair_cloud') | |||
| } | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
blank line? Can you remove it?
|
@dgutride This looks great! I also verified that it works well in the UI 👍 |
dgutride
force-pushed
the
convert_cloud_key_pairs_to_angular
branch
from
d0e7320
to
94a29cf
Compare
|
@AparnaKarve - I've tried to squash 760a257 and 4630ba3 (since the second one is more of an 'undo' action) but the squash command will only allow me to compress onto the previous commit. Would you like me to flatten that entire set? |
|
@dgutride Let's discuss this on gitter on how to squash those 2 non-consecutive commits. |
| :required => '', | ||
| 'pf-select' => true) | ||
| :javascript | ||
| miqInitSelectPicker(); |
There was a problem hiding this comment.
@dgutride Thought I made a comment here yesterday...but apparently not.
You can remove this :javascript block completely and instead use the directive selectpicker-for-select-tag for the select_tag. Also, you would not need the pf-select directive.
…d providers and add angular controller.
…o body parameters for POST of new key data.
dgutride
force-pushed
the
convert_cloud_key_pairs_to_angular
branch
from
94a29cf
to
bf6605e
Compare
|
Checked commits dgutride/manageiq@3580a50~...bf6605e with ruby 2.2.4, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@dclarizio Verified that the form works well in the UI. |
Purpose or Intent
Convert the Compute > Clouds > Key Pairs form to Angular.
This included modifying the controller to remove any @edit variables and retrieve cloud providers for the dropdown. The create method was also changed to allow for a POST from the new Angular controller. All other functionality should be identical to the way it currently works.
Steps for Testing/QA