Enhancement/251 migrate from bower to npm #296

AllenBW · 2016-10-28T12:45:39Z

☠️ bower, long live bower 👑

Re-configures process for adding dependencies, need to add documentation on this, was thinking of starting a guides folder in where I can explain the process (long story short npm install, add fep location in the stylesheet.html or javascript.html, update test config dependencies to reflect)

Renames a number of gulp tasks to better align with actual function
Removes a number of unnecessary gulp tasks relating to building the test environment

End of the day, not much changed here! Though I would love some 👀 from the following :
@chriskacerguis @himdel @jeff-phillips-18 @dtaylor113

closes #251

…to function nominally

Yarn presently has an issue running these, since they are not used, will be removed for now

Removes unnecessary specs.html

AllenBW · 2016-10-28T13:26:59Z

@miq-bot add_label enhancement

dtaylor113 · 2016-10-28T13:31:27Z

client/app/components/components.module.js

@@ -5,7 +5,7 @@
    'app.core',
    'ui.bootstrap',
    'patternfly',
-    'ngSVGAttributes',
+    'svgBaseFix',


Cloned this branch, new svgBaseFix lib is working. LGTM

chriskacerguis · 2016-10-28T13:34:44Z

.travis.yml

 install:
- yarn install
- bower install -F
+- yarn install --force


Why --force? Using --force could do very bad things

Thats a good question, travis 💩's if its absent, I would say that force isn't so bad, just fetches deps fresh! https://yarnpkg.com/en/docs/cli/install#toc-yarn-install-force

chriskacerguis · 2016-10-28T15:46:13Z

👍 for me, waiting for @himdel and @martinpovolny to take a look.

himdel · 2016-10-29T05:44:33Z

gulp/config.js

@@ -83,7 +69,57 @@ module.exports = (function() {
    var options = {
      files: [].concat(
        './node_modules/phantomjs-polyfill/bind-polyfill.js',
-        wiredep({devDependencies: true}).js,
+        './node_modules/jquery/dist/jquery.js',


This is problematic ;). Is there any way to make wiredep work? Is it just that wiredep can't read package.json or pick the right libraries, or is it also that those don't have the necessary info on what to include?

People will notice that adding the lib is not enough and add it to javascripts, but.. these test deps will get out of sync soon, I'm afraid..

wiredep is for bower dependencies only ever just bower dependencies, i TOTALLY feel what you are feeling, wait what, more than one place to update deps? I kinda ran outta time and ideas on how to getting those in here, open to suggestions!

ultimately i was going to write up some documentation on how to correctly add dependencies and keep in mind, this is only until we move to angular 2! importing modules will change a great deal of what we presently do...

Aaah, too bad :( I was hoping Karma works like Jasmine and just loads a html file.

But oh well, you're right that this is temporary, so maybe people won't break it so much :) Something too keep an eye for when reviewing though ;)

himdel · 2016-10-29T05:46:47Z

server/utils/serviceApp.js

@@ -9,6 +9,6 @@ var router = express.Router();

 router.use(express.static('./client'));
 router.use(express.static('./.tmp'));
-router.use(express.static('./bower_components'));
+router.use(express.static('./node_modules'));


This will need to be updated in the apache config as well ;)

really? our build process hasn't changed, we don't use bower components in the build, we use those bundled concatenated files, this still builds the same way as before.

Console templates ;-)

oh yeah soooo those are now served from a folder renamed vendor (also pushed to that folder)
but yeah that changed whos da person to beep for that change?

Uh, I guess that would be me :D

Ok, I'm seeing they're now copied to public/ui/service/vendor/{no-vnc,spice-html5-bower}.. The tricky part here is that we need to find them on the same url both in devel mode (served by node) and in production mode (served by apache) .. but that can be acomplished by redirecting /ui/service/vendor to /node_modules in node, and assuming the /ui/service/vendor/... URL, I think.

And then, the only change needed outside manageiq-ui-service would be https://github.com/ManageIQ/manageiq/blob/3921e87915b5a69937b9d4a70bb24ab71b97c165/gems/pending/util/miq_apache/miq_apache.rb#L209 .. that bower_components was there for exactly that reason (and only that reason, so you should be able to safely change that to vendor)

@himdel acceptable for me to submit a second pr making the above change? or is this a thing fun enough to rope @simaishi into? 👐 🙌

I'd say feel free to do it, the more people understand these things the better :-) but do tag us there.. :-)

himdel · 2016-10-29T06:06:37Z

(EDIT: never mind)

When running gulp build, I'm getting

[05:50:39] gulp-inject 1 files into index.html.
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/bootstrap-select/dist/css/bootstrap-select.css
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/bootstrap-switch/dist/css/bootstrap3/bootstrap-switch.css
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/bootstrap-touchspin/src/jquery.bootstrap-touchspin.css
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/c3/c3.css
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/google-code-prettify/bin/prettify.min.css
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/google-code-prettify/bin/prettify.min.js
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/c3/c3.js
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/bootstrap-datepicker/dist/js/bootstrap-datepicker.min.js
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/bootstrap-select/dist/js/bootstrap-select.js
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/bootstrap-switch/dist/js/bootstrap-switch.js
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/bootstrap-touchspin/src/jquery.bootstrap-touchspin.js
[05:50:39] Plumber found unhandled error:
 Error: Error: File not found with singular glob: /home/himdel/manageiq-ui-service/node_modules/patternfly-bootstrap-treeview/dist/bootstrap-treeview.min.js

And looks like it's right, those modules' directories are empty, except for a node_modules/jquery..

Either way, gulp build fails .. is it just me?

EDIT: .. that happens only with yarn 0.15, 0,16.1 is fine :)

himdel · 2016-10-29T06:15:36Z

This looks good, except for that manual test dependency list.. Any chance we could include javascripts.html in the spec html as well instead of that?

AllenBW · 2016-10-29T12:50:57Z

@himdel sooooooo we can't require the file because javascripts.html is a bunch of scripts rather than a bunch of file locations (which is required in the tests)

totally open to suggestions on how to solve this! because it is a mild problem

silver lining, if ever the list starts to deteriorate, tests will fail, chaos will FOLLOW

also thanks for looking <3 super appreciate it.

Fryguy · 2016-11-01T13:28:21Z

cc @simaishi for build concerns

AllenBW added 7 commits October 27, 2016 23:32

Removes bower including wiredep, updates and reconfigures gulp tasks …

c20d16c

…to function nominally

Update dependencies for build and test

1784a26

Update documentation to reflect removal of bower

686617e

Remove unused npm scripts

39f51f5

Yarn presently has an issue running these, since they are not used, will be removed for now

Readd node-sass

233626d

Remove unnecessary gulp tasks, serve-specs, buildspecs

b86de53

Removes unnecessary specs.html

Style fixes, force travis to grab new deps

d406048

dtaylor113 reviewed Oct 28, 2016

View reviewed changes

dtaylor113 approved these changes Oct 28, 2016

View reviewed changes

chriskacerguis reviewed Oct 28, 2016

View reviewed changes

chriskacerguis self-assigned this Oct 28, 2016

chriskacerguis added this to the Sprint 49 Ending Nov 14, 2016 milestone Oct 28, 2016

chriskacerguis added the enhancement label Oct 28, 2016

himdel reviewed Oct 29, 2016

View reviewed changes

chriskacerguis approved these changes Oct 31, 2016

View reviewed changes

chriskacerguis added the euwe/no label Oct 31, 2016

chriskacerguis merged commit 43d284a into ManageIQ:master Oct 31, 2016

AllenBW mentioned this pull request Oct 31, 2016

Update bower_components to vendor and self_service to ui/service paths ManageIQ/manageiq#12311

Merged

AllenBW deleted the enhancement/251-migrate-from-bower-to-npm branch November 1, 2016 11:27

AllenBW mentioned this pull request Nov 1, 2016

Separate code_tour from developer_setup from readme #306

Merged

This was referenced Nov 10, 2016

Reintroduce npm test, so that travis runs gulp test #329

Merged

[WIP] Move frontend deps from bower to npm ManageIQ/manageiq#12581

Closed

himdel mentioned this pull request Dec 23, 2016

[WIP] Move frontend deps from bower to npm ManageIQ/manageiq-ui-classic#20

Closed

7 tasks

himdel mentioned this pull request Jan 4, 2019

Drop /server, and dependencies, not used anymore #1517

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement/251 migrate from bower to npm #296

Enhancement/251 migrate from bower to npm #296

AllenBW commented Oct 28, 2016

AllenBW commented Oct 28, 2016

dtaylor113 Oct 28, 2016

chriskacerguis Oct 28, 2016

AllenBW Oct 28, 2016

chriskacerguis commented Oct 28, 2016

himdel Oct 29, 2016

AllenBW Oct 29, 2016

himdel Oct 29, 2016

himdel Oct 29, 2016

AllenBW Oct 29, 2016

himdel Oct 29, 2016

AllenBW Oct 29, 2016 •

edited

Loading

himdel Oct 29, 2016

AllenBW Oct 31, 2016

himdel Oct 31, 2016

himdel commented Oct 29, 2016 •

edited

Loading

himdel commented Oct 29, 2016

AllenBW commented Oct 29, 2016 •

edited

Loading

Fryguy commented Nov 1, 2016

Enhancement/251 migrate from bower to npm #296

Enhancement/251 migrate from bower to npm #296

Conversation

AllenBW commented Oct 28, 2016

AllenBW commented Oct 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chriskacerguis commented Oct 28, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AllenBW Oct 29, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himdel commented Oct 29, 2016 • edited Loading

himdel commented Oct 29, 2016

AllenBW commented Oct 29, 2016 • edited Loading

Fryguy commented Nov 1, 2016

AllenBW Oct 29, 2016 •

edited

Loading

himdel commented Oct 29, 2016 •

edited

Loading

AllenBW commented Oct 29, 2016 •

edited

Loading