Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration support for websocket logging level #13265

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Add configuration support for websocket logging level #13265

merged 1 commit into from
Dec 20, 2016

Conversation

skateman
Copy link
Member

@skateman skateman commented Dec 20, 2016 •
edited by miq-bot
Loading

I somehow forgot this feature, sorry guys 😢

Resolves #13259

@miq-bot assign @jrafanie

@skateman
Copy link
Member Author

@miq-bot will complain about $lenovo_log which is a false-positive and fixed in #13266

@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2016

Checked commit skateman@09d3a65 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 1 offense detected

lib/vmdb/loggers.rb

@jrafanie
Copy link
Member

LGTM, tested it locally. Note, this PR should go back to euwe but it might conflict because the lenovo logger didn't go back in #12084 so we might have to do a manual backport if it fails to cherry-pick.

@jrafanie
Copy link
Member

Thanks @skateman

@jrafanie jrafanie merged commit cb6fb25 into ManageIQ:master Dec 20, 2016
@jrafanie jrafanie added this to the Sprint 51 Ending Jan 2, 2017 milestone Dec 20, 2016
@skateman skateman deleted the websocket-log-level branch December 20, 2016 15:20
@miq-bot
Copy link
Member

miq-bot commented Dec 20, 2016

@skateman unrecognized command 'will', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

@simaishi
Copy link
Contributor

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1411993

simaishi pushed a commit that referenced this pull request Jan 16, 2017
@jrafanie @simaishi
Merge pull request #13265 from skateman/websocket-log-level
2bd2e7c 
Add configuration support for websocket logging level
(cherry picked from commit cb6fb25)

https://bugzilla.redhat.com/show_bug.cgi?id=1412285
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 2bd2e7c50dfa48c2dbf83bf56130a5cb14f026d3
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Tue Dec 20 10:20:01 2016 -0500

    Merge pull request #13265 from skateman/websocket-log-level
    
    Add configuration support for websocket logging level
    (cherry picked from commit cb6fb25f4a6299c86cde77bb26ff7e30deb4df31)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1412285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrafanie jrafanie

Labels
core/workers enhancement euwe/backported ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @jrafanie @simaishi @chessbyte