Rescue worker class sync_workers exceptions and move on #13976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to ManageIQ#13958 In the above issue, if ManageIQ::Providers::StorageManager::CinderManager::EventCatcher.sync_workers raises an exception, the server process exits fatally and all workers exit `Error heartbeating to MiqServer because DRb::DRbConnError: Connection reset by peer Worker exiting.` We now rescue any exceptions here, log it and move on to other worker classes.
jrafanie
force-pushed
the
rescue_worker_sync_workers
branch
from
850ee87
to
7412ec6
Compare
|
Checked commit jrafanie@7412ec6 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@jrafanie Is there a BZ for this? Can you please create one if it doesn't exist? |
|
@simaishi thanks! Here: https://bugzilla.redhat.com/show_bug.cgi?id=1429020 |
simaishi
pushed a commit
that referenced
this pull request
Mar 7, 2017
Rescue worker class sync_workers exceptions and move on (cherry picked from commit aaf7406) https://bugzilla.redhat.com/show_bug.cgi?id=1429648
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13958
https://bugzilla.redhat.com/show_bug.cgi?id=1429020
In the above issue, if
ManageIQ::Providers::StorageManager::CinderManager::EventCatcher.sync_workersraises an exception, the server process exits fatally and
all workers exit
Error heartbeating to MiqServer because DRb::DRbConnError: Connection reset by peer Worker exiting.We now rescue any exceptions here, log it and move on to other worker
classes.