Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/DRY logging for job #14342

Merged
merged 2 commits into from Mar 15, 2017

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented Mar 15, 2017

Introduce Job#attributes_log - The Job's attributes that are logged.

This allows us to modify the logged attributes more easily.

@miq_bot add-label core, refactoring

@yrudman
Copy link
Contributor Author

yrudman commented Mar 15, 2017

@kbrock could you review

@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2017

Checked commits yrudman/manageiq@9024bee~...70076e1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks good. 👍

Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. will allow us to merge job and task more easily

@chessbyte chessbyte requested a review from kbrock March 15, 2017 15:50
Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chessbyte chessbyte assigned chessbyte and unassigned gtanzillo Mar 15, 2017
@chessbyte chessbyte merged commit e02e529 into ManageIQ:master Mar 15, 2017
@chessbyte chessbyte added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 15, 2017
@yrudman yrudman deleted the refactor-logging-for-job branch March 15, 2017 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants