Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to show vm/image related info in audit log when deleting vm/image #17504

Merged
merged 3 commits into from
Jun 14, 2018

Conversation

hsong-rh
Copy link
Contributor

@hsong-rh hsong-rh commented May 31, 2018

Added extra vm or image related information in audit log file when removing them from providers.

https://bugzilla.redhat.com/show_bug.cgi?id=1434762

@hsong-rh
Copy link
Contributor Author

@roliveri Please review.

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2018

Checked commits hsong-rh/manageiq@083ce04~...960bb18 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@hsong-rh
Copy link
Contributor Author

@roliveri Can you review this? I removed the changes for user's information.

Copy link
Member

@roliveri roliveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsong-rh is there anyone else who should review this?

@hsong-rh
Copy link
Contributor Author

@jrafanie Would you mind reviewing this?

@jrafanie jrafanie merged commit fa75c39 into ManageIQ:master Jun 14, 2018
@jrafanie jrafanie added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants