Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure MiqSchedule#name is unique for ServiceTemplate orders #17696

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Ensure MiqSchedule#name is unique for ServiceTemplate orders #17696

merged 1 commit into from
Jul 13, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 12, 2018

@bdunne bdunne requested review from gtanzillo and AllenBW July 12, 2018 13:52
@bdunne bdunne mentioned this pull request Jul 12, 2018
Merged
@bdunne bdunne force-pushed the ServiceTemplate_Schedule_name_validation branch from 88987ae to 0b358b8 Compare July 12, 2018 14:05
@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2018

Checked commit bdunne@0b358b8 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@AllenBW
Copy link
Member

AllenBW commented Jul 12, 2018

Will review shortly!! <3 <3 <3

@JPrause
Copy link
Member

JPrause commented Jul 12, 2018

@miq-bot add_label blocker

@bdunne bdunne mentioned this pull request Jul 13, 2018
Merged
@kbrock kbrock merged commit d101c79 into ManageIQ:master Jul 13, 2018
@kbrock kbrock added this to the Sprint 90 Ending Jul 16, 2018 milestone Jul 13, 2018
@kbrock kbrock self-assigned this Jul 13, 2018
@bdunne bdunne deleted the ServiceTemplate_Schedule_name_validation branch July 13, 2018 13:05
AllenBW
AllenBW reviewed Jul 13, 2018
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah! Was gonna say, lg2m 😆

@simaishi
Copy link
Contributor

simaishi commented Jul 25, 2018 •
edited
Loading

@bdunne #17594 isn't in gaprindashvili branch (as it's not associated with a blocker BZ). What should happen to this PR for backport?

Edit: never mind... will backport this after #17594 comes to G-branch.

simaishi pushed a commit that referenced this pull request Jul 26, 2018
@kbrock @simaishi
Merge pull request #17696 from bdunne/ServiceTemplate_Schedule_name_v…
7cb0e55 
…alidation

Ensure MiqSchedule#name is unique for ServiceTemplate orders
(cherry picked from commit d101c79)

https://bugzilla.redhat.com/show_bug.cgi?id=1608351
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 7cb0e55c0105a28c0accc61302b0775fc8a03fc4
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Fri Jul 13 09:04:57 2018 -0400

    Merge pull request #17696 from bdunne/ServiceTemplate_Schedule_name_validation
    
    Ensure MiqSchedule#name is unique for ServiceTemplate orders
    (cherry picked from commit d101c7997d556f08a7b0747703654ba74915b7da)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1608351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW left review comments

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@kbrock kbrock

Labels
blocker bug enhancement gaprindashvili/backported lifecycle/provisioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bdunne @miq-bot @AllenBW @JPrause @simaishi @kbrock