Maintenance must run VACUUM to avoid long held locks #17713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1601264 It's hard to say which tables may or may not grow too large that we cannot easily run VACUUM FULL on them as part of maintenance. Therefore we should do the safest thing possible and run VACUUM for routine maintenance and leave VACUUM FULL when table bloat becomes a problem. Some tables, such as vim_performance_states can grow so large that a VACUUM FULL could lock up the table for many minutes and could fail to complete during the normal 10 minute queue timeout.
|
@carbonin please review |
|
Checked commit jrafanie@8da858f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/lib/extensions/ar_base_spec.rb
|
carbonin
approved these changes
Jul 16, 2018
simaishi
pushed a commit
that referenced
this pull request
Sep 11, 2018
…regular_vacuum Maintenance must run VACUUM to avoid long held locks (cherry picked from commit b11ffa9) https://bugzilla.redhat.com/show_bug.cgi?id=1603026
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1601264
It's hard to say which tables may or may not grow too large that we
cannot easily run VACUUM FULL on them as part of maintenance. Therefore
we should do the safest thing possible and run VACUUM for routine
maintenance and leave VACUUM FULL when table bloat becomes a problem.
Some tables, such as vim_performance_states can grow so large that a
VACUUM FULL could lock up the table for many minutes and could fail
to complete during the normal 10 minute queue timeout.