Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage service edit #22425

Merged
merged 1 commit into from
Mar 28, 2023
Merged

storage service edit #22425

merged 1 commit into from
Mar 28, 2023

Conversation

OrGur1987
Copy link
Contributor

@OrGur1987 OrGur1987 mentioned this pull request Mar 23, 2023
Closed
4 tasks
@miq-bot
Copy link
Member

miq-bot commented Mar 23, 2023

Checked commit Autosde@740fb50 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare self-assigned this Mar 28, 2023
@agrare
Copy link
Member

agrare commented Mar 28, 2023

@OrGur1987 a little more of a description would be helpful, the linked issue is great but a description of what just this PR is helps without having to go elsewhere to see what this is for.

Simply Add an edit product feature for Storage Services would do

@agrare agrare merged commit 37a1f7e into ManageIQ:master Mar 28, 2023
@kbrock kbrock mentioned this pull request Mar 29, 2023
Merged
1 task
@OrGur1987
Copy link
Contributor Author

OrGur1987 commented Apr 13, 2023 •
edited

@agrare
come to think of it, shouldn't we add storage_service_edit to miq_user_roles.yml as well?
I see the EvmRole-physical_storages_user has cloud_volume_edit and host_initiator_group_edit..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@agrare agrare

Labels
enhancement providers/storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrGur1987 @miq-bot @agrare