[WIP] Method list dialog #22921
Open
[WIP] Method list dialog #22921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
jeffibm
force-pushed
the
method-list-dialog
branch
3 times, most recently
from
d7b5716
to
f0b2678
Compare
jeffibm
force-pushed
the
method-list-dialog
branch
from
f0b2678
to
f552314
Compare
|
Checked commit jeffibm@f552314 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
kbrock
reviewed
May 7, 2024
| if method_ids.present? | ||
| where(:id => method_ids.split(',').map(&:to_i)) | ||
| else | ||
| where(nil) |
There was a problem hiding this comment.
unsure, but think a simple self would work here.
There was a problem hiding this comment.
Hey @kbrock , Yes, self methods should work here.
I used scope since the query was not that complex.
but, while using the self I was not able to chain it like -
MiqAeMethod
.name_path_search(params[:search])
.domain_search(params[:domain_id])
.selected_methods(params[:ids])
.select("id, relative_path, name")
.order('name')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR - ManageIQ/manageiq-ui-classic#9059
This PR is an RnD work related to the search feature for the selection of the method.
Might be helpful for ManageIQ/manageiq-ui-classic#9047