Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Method list dialog #22921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions app/models/miq_ae_method.rb
Expand Up @@ -30,6 +30,22 @@ class MiqAeMethod < ApplicationRecord
AVAILABLE_SCOPES = ["class", "instance"]
validates_inclusion_of :scope, :in => AVAILABLE_SCOPES

scope :name_path_search, lambda { |search|
where('name ILIKE ? or relative_path ILIKE ?', "%#{search}%", "%#{search}%") if search.present?
}

scope :domain_search, lambda { |domain_id|
where(:domain_id => domain_id) if domain_id.present?
}

scope :selected_methods, lambda { |method_ids|
if method_ids.present?
where(:id => method_ids.split(',').map(&:to_i))
else
where(nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure, but think a simple self would work here.

Copy link
Member Author

@jeffibm jeffibm May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kbrock , Yes, self methods should work here.

I used scope since the query was not that complex.

but, while using the self I was not able to chain it like -

MiqAeMethod
              .name_path_search(params[:search])
              .domain_search(params[:domain_id])
              .selected_methods(params[:ids])
              .select("id, relative_path, name")
              .order('name')

end
}

def self.available_languages
AVAILABLE_LANGUAGES
end
Expand Down