-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Remove deletion of data/git_repos for EmbeddedAnsible tests #22960
base: master
Are you sure you want to change the base?
Conversation
I'm very happy for this change. Do we need to clean these up in another way? Like deleting all files underneath that directory (may cause issues for local development though) |
Yeah I thought I'd have to delete all dirs+files under this directory, but after removing this line and running this spec file I didn't see any files in this directory left over, and and I don't see anything in the embedded_ansible seed that does anything with git_repos. If I run the full suite I do see leftover locks, so I think other specs need to clean up their own locks and this was hiding that. |
Okay it looks like leftover locks are from these two spec files (not surprisingly), |
Does anything ever delete these git_repository lockfiles at runtime? |
fafbe9f
to
6fa3221
Compare
Checked commits agrare/manageiq@379aebe~...6fa3221 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
WIP until I cover the other specs that leave these lockfiles around |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
The data/git_repos directory doesn't appear to be used but it does leave local git changes when running the embedded_ansible_spec.rb