[WIP] Remove deletion of data/git_repos for EmbeddedAnsible tests

[agrare]

The data/git_repos directory doesn't appear to be used but it does leave local git changes when running the embedded_ansible_spec.rb

$ git status

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	deleted:    data/git_repos/locks/.gitkeep

[kbrock]

I'm very happy for this change.
This frustrated me but I hadn't tracked it down.

Do we need to clean these up in another way? Like deleting all files underneath that directory (may cause issues for local development though)

[agrare]

Do we need to clean these up in another way? Like deleting all files underneath that directory (may cause issues for local development though)

Yeah I thought I'd have to delete all dirs+files under this directory, but after removing this line and running this spec file I didn't see any files in this directory left over, and and I don't see anything in the embedded_ansible seed that does anything with git_repos.

If I run the full suite I do see leftover locks, so I think other specs need to clean up their own locks and this was hiding that.

[agrare]

Okay it looks like leftover locks are from these two spec files (not surprisingly), spec/models/git_repository_spec.rb and spec/models/manageiq/providers/embedded_ansible/automation_manager/configuration_script_source_spec.rb.

[agrare]

Does anything ever delete these git_repository lockfiles at runtime?

[miq-bot]

Checked commits agrare/manageiq@379aebe~...6fa3221 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

[agrare]

WIP until I cover the other specs that leave these lockfiles around