Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mixing enumerable into string #380

Merged
merged 1 commit into from Aug 13, 2014

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Aug 13, 2014

AwesomeSpawn is throwing errors for me because we mix Enumerable into String.
Infinite recursion nasty stuff.

@jrafanie suggested it was time to remove this crutch?

@kbrock
Copy link
Member Author

kbrock commented Aug 13, 2014

@jrafanie
Copy link
Member

I ❤️ this. We should blow up if we're still doing ruby 1.8's String#each

remove ord (standard in string)
@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2014

Checked commit kbrock@fe3833c with rubocop 0.21.0
0 files checked, 0 offenses detected
Everything looks good. 🍪

@kbrock
Copy link
Member Author

kbrock commented Aug 13, 2014

@jrafanie I also noticed that String.ord is available in rails up to 4.0.2. didn't look too hard into that.
Do we want to add deprications? rails-doc

@jrafanie
Copy link
Member

Yay!!! Thanks for cleaning this up.

String#ord is a possibility, not sure though since we might use that in a non-rails context in the smartproxy or elsewhere. We can certainly deprecate it though.

jrafanie added a commit that referenced this pull request Aug 13, 2014
remove mixing enumerable into string
@jrafanie jrafanie merged commit e79ba90 into ManageIQ:master Aug 13, 2014
@kbrock kbrock deleted the remove_string_enumerable branch August 13, 2014 14:53
@AparnaKarve AparnaKarve mentioned this pull request Aug 13, 2014
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants