Set expected feature count in one place instead of 3 #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonas
force-pushed
the
optimizeMiqFeatureSpec
branch
from
82ae2ea
to
22d1735
Compare
|
@abonas, I like it, maybe expected_feature_count as the variable name to make it clear it is the expected value. |
np, will rename |
abonas
force-pushed
the
optimizeMiqFeatureSpec
branch
from
22d1735
to
aa3a4e3
Compare
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
abonas
force-pushed
the
optimizeMiqFeatureSpec
branch
from
aa3a4e3
to
cc337da
Compare
|
Checked commit abonas@cc337da with rubocop 0.33.0 and haml-lint 0.13.0 |
|
@jrafanie ready to merge? |
|
🎉 |
jrafanie
added a commit
that referenced
this pull request
Sep 1, 2015
Set expected feature count in one place instead of 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce manual work by setting feature count in one place instead of 3