Enable and start the evmserverd service after the database is configured #4989
Conversation
| @@ -64,6 +64,9 @@ def activate | |||
|
|
|||
| def post_activation | |||
| ServiceGroup.new.restart_services | |||
| evm_service = LinuxAdmin::Service.new("evmserverd") | |||
| evm_service.enable | |||
| evm_service.start | |||
There was a problem hiding this comment.
this is good
Can we do:
LinuxAdmin::Service.new("evmserverd").enable.startHmm, may require a change over in Service. I'll put PR in for that if it doesn't exist.
this requires test changes (and_call_original)
There was a problem hiding this comment.
Looks like we should be able to do that
(https://github.com/ManageIQ/linux_admin/blob/master/lib/linux_admin/service/systemd_service.rb#L11)
There was a problem hiding this comment.
cool. so self is already in there. if you have the bandwidth, this would be cool. otherwise, just say no and we can merge.
|
I'm good with this regardless of comments. 👍 |
carbonin
force-pushed
the
enable_evmserverd_after_db_configuration
branch
from
1ab4254
to
dc819dd
Compare
| @@ -64,6 +64,7 @@ def activate | |||
|
|
|||
| def post_activation | |||
| ServiceGroup.new.restart_services | |||
| evm_service = LinuxAdmin::Service.new("evmserverd").enable.start | |||
There was a problem hiding this comment.
@carbonin Why are we setting the local variable evm_service just as method is about to exit? Or is it not a local variable?
There was a problem hiding this comment.
Ah you're right, forgot to drop that when I combined the new enable and start lines. I'll change it now.
carbonin
force-pushed
the
enable_evmserverd_after_db_configuration
branch
from
dc819dd
to
7321142
Compare
|
Checked commit carbonin@7321142 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
…figuration Enable and start the evmserverd service after the database is configured
The service will be enabled and started after the database is configured by the changes in ManageIQ/manageiq#4989 https://bugzilla.redhat.com/show_bug.cgi?id=1272604
@kbrock @simaishi
https://bugzilla.redhat.com/show_bug.cgi?id=1272604