Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPICE: Add missing compatibility file for IE10. #5584

Merged
merged 1 commit into from Nov 25, 2015

Conversation

martinpovolny
Copy link

@miq-bot
Copy link
Member

miq-bot commented Nov 24, 2015

Checked commit martinpovolny@6244a21 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@martinpovolny
Copy link
Author

@bmclaughlin : you have some IEs and stuff, can you, please, review this one?

@bmclaughlin
Copy link
Contributor

Will do @martinpovolny.

@Fryguy
Copy link
Member

Fryguy commented Nov 24, 2015

Code-wise pretty straightforward, so when @bmclaughlin comes back with a 👍, we can merge

@bmclaughlin
Copy link
Contributor

👍 IE11
👍 IE10
👎 IE9, throws the following error:
SCRIPT5009: 'ArrayBuffer' is undefined spicearraybuffer.self.js?body=1, line 54 character 1

@martinpovolny
Copy link
Author

@bmclaughlin : I expect several issues in IE9 or earlier that I do not try to address in this PR.

@bmclaughlin
Copy link
Contributor

@martinpovolny then I'd say this is good to go.

@martinpovolny
Copy link
Author

Btw: https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support

January 12, 2016, only IE11+

@jonnyfiveiq : take the burden off our beaten bodies!

@jrafanie
Copy link
Member

Btw: https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support

January 12, 2016, only IE11+

@jonnyfiveiq : take the burden off our beaten bodies!

Sorry @bmclaughlin @martinpovolny, sounds like fun 😭

@bmclaughlin
Copy link
Contributor

@martinpovolny, looks like you're off the hook for the IE9 error, although the error in master is much more entertaining:
Line: 51 Error: WebSocket unavailable. You need to use a different browser.

martinpovolny pushed a commit that referenced this pull request Nov 25, 2015
SPICE: Add missing compatibility file for IE10.
@martinpovolny martinpovolny merged commit 3885cdf into ManageIQ:master Nov 25, 2015
@martinpovolny martinpovolny added this to the Sprint 33 Ending Dec 7, 2015 milestone Nov 25, 2015
dclarizio pushed a commit to dclarizio/manageiq that referenced this pull request Dec 16, 2015
SPICE: Add missing compatibility file for IE10.

https://bugzilla.redhat.com/show_bug.cgi?id=1279357

5.5 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1289247

clean cherry-pick, upstream PR: ManageIQ#5584

See merge request !546
@kbrock
Copy link
Member

kbrock commented Jan 6, 2016

this doesn't fix it in production mode
put in a fix at the source: abenari/spice-html5-rails#4

@martinpovolny martinpovolny deleted the bz_1279357 branch November 28, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants