New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPICE: Add missing compatibility file for IE10. #5584
Conversation
Checked commit martinpovolny@6244a21 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
@bmclaughlin : you have some IEs and stuff, can you, please, review this one? |
Will do @martinpovolny. |
Code-wise pretty straightforward, so when @bmclaughlin comes back with a 👍, we can merge |
👍 IE11 |
@bmclaughlin : I expect several issues in IE9 or earlier that I do not try to address in this PR. |
@martinpovolny then I'd say this is good to go. |
Btw: https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support January 12, 2016, only IE11+ @jonnyfiveiq : take the burden off our beaten bodies! |
Sorry @bmclaughlin @martinpovolny, sounds like fun 😭 |
@martinpovolny, looks like you're off the hook for the IE9 error, although the error in master is much more entertaining: |
SPICE: Add missing compatibility file for IE10.
SPICE: Add missing compatibility file for IE10. https://bugzilla.redhat.com/show_bug.cgi?id=1279357 5.5 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1289247 clean cherry-pick, upstream PR: ManageIQ#5584 See merge request !546
this doesn't fix it in production mode |
https://bugzilla.redhat.com/show_bug.cgi?id=1279357