Apply RBAC filtering to the foreman tree objects #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -946,6 +944,21 @@ def process_show_list(options = {}) | |||
| super | |||
| end | |||
|
|
|||
| def find_record(db, id) | |||
There was a problem hiding this comment.
suggest renaming db to klass or model
|
@gtanzillo Please review |
AparnaKarve
force-pushed
the
rbac_foreman
branch
from
ba8eb58
to
f0ef808
Compare
|
👍 Looks good to me |
AparnaKarve
force-pushed
the
rbac_foreman
branch
from
f0ef808
to
a1a5ad1
Compare
|
Checked commits AparnaKarve/manageiq@6ba3d19~...a1a5ad1 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 app/controllers/application_controller.rb
app/controllers/provider_foreman_controller.rb
app/presenters/tree_builder.rb
app/presenters/tree_builder_foreman.rb
|
dclarizio
pushed a commit
that referenced
this pull request
Dec 3, 2015
Apply RBAC filtering to the foreman tree objects
dclarizio
pushed a commit
to dclarizio/manageiq
that referenced
this pull request
Dec 16, 2015
BZ1247715 - Apply RBAC filtering to the foreman tree objects Clean cherry-pick Upstream PR - ManageIQ#5665 Apply RBAC filtering to the Foreman tree nodes based on the logged-in user's tag settings. https://bugzilla.redhat.com/show_bug.cgi?id=1247715 See merge request !582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply RBAC filtering to the Foreman tree nodes based on the logged-in user's tag settings.
https://bugzilla.redhat.com/show_bug.cgi?id=1247715