Use chronyd instead of ntpdate #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also requires ManageIQ/linux_admin#146 |
carbonin
changed the title
|
Marking as WIP until LinuxAdmin PR is merged |
|
Looks good once the LinuxAdmin change is in. Nice work @carbonin |
|
Look at all the 鉁傦笍 馃敟 (deletions) |
| @ntp_settings = ntp_settings | ||
| end | ||
|
|
||
| def apply_ntp_server_settings(settings) | ||
| return unless Sys::Platform::IMPL == :linux |
There was a problem hiding this comment.
do we want/need a log message that says we don't support this platform?
There was a problem hiding this comment.
Not sure, I just tried it keep it as close to what was being done here.
This will probably only be an issue when running in development (not on an appliance) right?
carbonin
force-pushed
the
use_chrony_instead_of_ntpdate
branch
from
e00a4dd
to
f63db23
Compare
carbonin
changed the title
|
@miq-bot rm_label wip |
|
|
LGTM
|
馃憤 LGTM |
carbonin
force-pushed
the
use_chrony_instead_of_ntpdate
branch
from
f63db23
to
d4b1d47
Compare
ntpdate is to be retired and chronyd is the new default time sync daemon on Centos 7 and has been running on the appliance along side our code running ntpdate. This opens up the possibility of trying to sync with both the timeservers configured in `/etc/chrony.conf` which have always been set to the defaults and `/etc/ntp.conf` which is what is edited when the user changes ntp servers. Also the motivation behind using a custom script which ran ntpdate was to have the schedule worker protected from large jumps in time by dropping an exit file and waiting for it to exit. The schedule worker has not responded to the exit file since commit 85d34a9a869ce2eefcf69d7c58644a24cc2359ba was merged in 2012. https://bugzilla.redhat.com/show_bug.cgi?id=1275677
carbonin
force-pushed
the
use_chrony_instead_of_ntpdate
branch
from
d4b1d47
to
ffcf265
Compare
|
<github_pr_commenter_batch />Some comments on commits carbonin/manageiq@3ba88b3~...ffcf265 |
|
Checked commits carbonin/manageiq@3ba88b3~...ffcf265 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 spec/models/miq_server/rhn_mirror_spec.rb
|
|
^ I wish |
gtanzillo
added a commit
that referenced
this pull request
Dec 7, 2015
Use chronyd instead of ntpdate
dclarizio
pushed a commit
to dclarizio/manageiq
that referenced
this pull request
Dec 16, 2015
Use chrony instead of ntpdate ntpdate is to be retired and chronyd is the new default time sync daemon on Centos 7 and has been running on the appliance along side our code running ntpdate. This opens up the possibility of trying to sync with both the timeservers configured in `/etc/chrony.conf` which have always been set to the defaults and `/etc/ntp.conf` which is what is edited when the user changes ntp servers. Also the motivation behind using a custom script which ran ntpdate was to have the schedule worker protected from large jumps in time by dropping an exit file and waiting for it to exit. The schedule worker has not responded to the exit file since commit 85d34a9a was merged in 2012. Upstream PR: ManageIQ#5705 Two empty commits in upstream not cherry-picked to this branch. The other cherry-picks were clean. https://bugzilla.redhat.com/show_bug.cgi?id=1289321 See merge request !609
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ntpdateis to be retired and chronyd is the new default time sync daemon on Centos 7 and has been running on the appliance along side our code runningntpdate. This opens up the possibility of trying to sync with both the timeservers configured in/etc/chrony.confwhich have always been set to the defaults and/etc/ntp.confwhich is what is edited when the user changes ntp servers.Also the motivation behind using a custom script which ran
ntpdatewas to have the schedule worker protected from large jumps in time by dropping an exit file and waiting for it to exit.The schedule worker has not responded to the exit file since commit 85d34a9a869ce2eefcf69d7c58644a24cc2359ba was merged in 2012.
@jrafanie @gtanzillo
馃敟 鉁傦笍 ??
https://bugzilla.redhat.com/show_bug.cgi?id=1275677