Remove unused RssFeed.import_from_hash

[isimluk]

Unused since 1840a69.

Note that any records created by import_from_hash are sooner or later
removed by PRIMORDIAL_CLASSES seed. RssFeed records are kept
in sync with yaml data in product/alerts/rss/*.

[miq-bot]

Checked commit isimluk@dbb97fc with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

[chessbyte]

@gtanzillo @jrafanie please review

[jrafanie]

Looks good to me. @isimluk, I don't see MiqWidget.import_from_hash being called either...

It looks like MiqPolicy and MiqReport's versions are called though.

app/models/miq_policy/import_export.rb:    def import_from_hash(policy, options = {})
app/models/miq_report/import_export.rb:    def import_from_hash(report, options = nil)
app/models/miq_widget/import_export.rb:    def import_from_hash(widget, options = {})
app/models/rss_feed/import_export.rb:      def import_from_hash(rss, options = {})

@eclarizio Can you confirm?

[gtanzillo]

Looks good to me as well 👍

[eclarizio]

@jrafanie The only thing I can think of is I know I was working on an issue where a customer was using some rake tasks that we have out there (not sure if we put them out there? Here's the link: https://github.com/rhtconsulting/cfme-rhconsulting-scripts), and they use the import_from_hash method. I don't see anything related to the RssFeed, though.

[jrafanie]

Thanks @eclarizio. I agree, so, I think this is good to go and @isimluk can check out if MiqWidget.seed_from_hash is still needed ✂️ 🔥 ✂️ ... I don't see it being used anymore and it's not in the those consulting scripts you linked to.

[jrafanie]

👍 🔥 ✂️ 🍰 @isimluk