Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused RssFeed.import_from_hash #7856

Merged
merged 1 commit into from Apr 19, 2016

Conversation

Projects
None yet
6 participants
@isimluk
Copy link
Contributor

commented Apr 11, 2016

Unused since 1840a69.

Note that any records created by import_from_hash are sooner or later
removed by PRIMORDIAL_CLASSES seed. RssFeed records are kept
in sync with yaml data in product/alerts/rss/*.

Remove unused RssFeed.import_from_hash
Unused since 1840a69.

Note that any records created by import_from_hash are sooner or later
removed by PRIMORDIAL_CLASSES seed. That is because RssFeed records
are kept in sync with yaml data in product/alerts/rss/*.
@miq-bot

This comment has been minimized.

Copy link
Member

commented Apr 11, 2016

Checked commit isimluk@dbb97fc with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

@miq-bot miq-bot added wip and removed wip labels Apr 11, 2016

@chessbyte

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

@gtanzillo @jrafanie please review

@jrafanie

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

Looks good to me. @isimluk, I don't see MiqWidget.import_from_hash being called either...

It looks like MiqPolicy and MiqReport's versions are called though.

app/models/miq_policy/import_export.rb:    def import_from_hash(policy, options = {})
app/models/miq_report/import_export.rb:    def import_from_hash(report, options = nil)
app/models/miq_widget/import_export.rb:    def import_from_hash(widget, options = {})
app/models/rss_feed/import_export.rb:      def import_from_hash(rss, options = {})

@eclarizio Can you confirm?

@gtanzillo

This comment has been minimized.

Copy link
Member

commented Apr 18, 2016

Looks good to me as well 👍

@eclarizio

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

@jrafanie The only thing I can think of is I know I was working on an issue where a customer was using some rake tasks that we have out there (not sure if we put them out there? Here's the link: https://github.com/rhtconsulting/cfme-rhconsulting-scripts), and they use the import_from_hash method. I don't see anything related to the RssFeed, though.

@jrafanie

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

Thanks @eclarizio. I agree, so, I think this is good to go and @isimluk can check out if MiqWidget.seed_from_hash is still needed ✂️ 🔥 ✂️ ... I don't see it being used anymore and it's not in the those consulting scripts you linked to.

@jrafanie

This comment has been minimized.

Copy link
Member

commented Apr 19, 2016

👍 🔥 ✂️ 🍰 @isimluk

@jrafanie jrafanie merged commit 0d8bf29 into ManageIQ:master Apr 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.