Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse or save the UserAgent of login requests to have a meaningful session name #26

Closed
Tracked by #8
CrescentKohana opened this issue Apr 15, 2022 · 1 comment
Closed
Tracked by #8
Labels
enhancement New feature or request server Concerns Mangatsu server web Concerns Mangatsu web

Comments

@CrescentKohana
Copy link
Member

Either

  • Save the raw user agent as the session name and let client handle the parsing
  • OR
  • Parse the UserAgent and save the result

token, err := newJWT(*userUUID, "", credentials.ExpiresIn, credentials.SessionName, role)

@CrescentKohana CrescentKohana added enhancement New feature or request server Concerns Mangatsu server web Concerns Mangatsu web labels Apr 15, 2022
@CrescentKohana CrescentKohana changed the title Parse or save UserAgent of login requests to have a meaningful session name Parse or save the UserAgent of login requests to have a meaningful session name Apr 15, 2022
@CrescentKohana CrescentKohana mentioned this issue Apr 15, 2022
17 tasks
@CrescentKohana
Copy link
Member Author

This is a frontend issue as next-auth always sends node-fetch/1.0 (+https://github.com/bitinn/node-fetch) as the user agent.

Made the name a bit user-friendlier here Mangatsu/web@1589f6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server Concerns Mangatsu server web Concerns Mangatsu web
Projects
None yet
Development

No branches or pull requests

1 participant