Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks #997

Merged
merged 2 commits into from Oct 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions bibliopixel/control/action.py
Expand Up @@ -57,8 +57,8 @@ def set_root(self, root):

def receive(self, msg):
values = tuple(msg.values())
for a in self.actions:
a.receive(values)
for action in self.actions:
action.receive(values)

def __bool__(self):
return bool(self.actions)
Expand Down
2 changes: 1 addition & 1 deletion bibliopixel/control/control.py
Expand Up @@ -79,7 +79,7 @@ def _make_thread(self):
"""
Returns a new thread to run the loop for this control source.
"""
raise NotImplementedError
pass

def _msg_to_str(self, msg):
if msg is None:
Expand Down
2 changes: 1 addition & 1 deletion bibliopixel/control/midi.py
Expand Up @@ -56,7 +56,7 @@ def __init__(self, use_note_off=True, **kwds):
If True, map note_ons with velocity 0 to note_offs
If None, do not change none_ons or note_offs
"""
control.ExtractedControl.__init__(self, **kwds)
super().__init__(**kwds)
self.use_note_off = use_note_off

def messages(self):
Expand Down