Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: use checked-in genesis for --chain=manta #1024

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Feb 21, 2023

Description

First row generated locally by this commit, second from 402 CI job, third from checked-in genesis.

cargo run --release -- build-spec --chain manta --raw > ./manta-genesis.json
cargo run --release -- export-genesis-state --chain manta > ./manta-genesis.state
cargo run --release -- export-genesis-wasm --chain manta > ./manta-genesis.wasm
❯ sha256sum manta-genesis*
b50ea39241941e9bd88a2a51aaa4f0ae1ce86a11909554c3e44b46882b8ea8b7  manta-genesis.json
3caa9f599f578d7f7a3329fdf75785c6f0b9cedf62866b0d62cca77c0647bef6  manta-genesis.state
cd9a1c176685999458f99d6df5cc3d0937f65db9eb33632cf8100af378da3184  manta-genesis.wasm

❯ sha256sum Genesis-from-CI/manta-genesis.*
b50ea39241941e9bd88a2a51aaa4f0ae1ce86a11909554c3e44b46882b8ea8b7  Genesis-from-CI/manta-genesis.json
3caa9f599f578d7f7a3329fdf75785c6f0b9cedf62866b0d62cca77c0647bef6  Genesis-from-CI/manta-genesis.state
cd9a1c176685999458f99d6df5cc3d0937f65db9eb33632cf8100af378da3184  Genesis-from-CI/manta-genesis.wasm

❯ sha256sum genesis/manta-genesis.json 
b50ea39241941e9bd88a2a51aaa4f0ae1ce86a11909554c3e44b46882b8ea8b7  genesis/manta-genesis.json

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Garandor Garandor force-pushed the garandor/genesis-bump branch 2 times, most recently from 24f4772 to cbc858c Compare February 21, 2023 17:04
@Garandor Garandor added A-manta Area: Issues and PRs related to the Manta Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes labels Feb 21, 2023
@Garandor Garandor self-assigned this Feb 21, 2023
@Garandor Garandor marked this pull request as ready for review February 21, 2023 17:11
@Garandor Garandor changed the title use checked-in genesis for --chain=manta Minor: use checked-in genesis for --chain=manta Feb 21, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete manta_genesis.rs. Its in our git history, so we can always find it if needed.

It doesn't matter much to me, but I'm not sure I see the benefit of keeping the dead code (I think I remember we discussed keeping this)

@Garandor
Copy link
Contributor Author

I'm not sure I see the benefit of keeping the dead code

It was decided to keep it in order to easily and quickly see the genesis configuration as this info can't be gained from the raw genesis file. IMO we should keep it around at least until after launch when the accounts listed become no longer relevant

@Garandor Garandor merged commit f11ae03 into manta Feb 21, 2023
@Garandor Garandor deleted the garandor/genesis-bump branch February 21, 2023 20:42
@Garandor Garandor mentioned this pull request Feb 21, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants