Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.7.0 #1335

Merged
merged 8 commits into from
May 22, 2024
Merged

Release v4.7.0 #1335

merged 8 commits into from
May 22, 2024

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented May 15, 2024

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

ferrell-code and others added 2 commits May 15, 2024 16:13
Signed-off-by: Charles Ferrell <charlie@manta.network>
@Dengjianping Dengjianping added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime L-release Related to a release A-benchmark-checks A-integration-test-checks A-unit-test-checks L-fixed Log: Issues and PRs related to bug fixes labels May 18, 2024
@ferrell-code ferrell-code added L-skip Log: Will be skipped on changelog generation and removed L-fixed Log: Issues and PRs related to bug fixes labels May 19, 2024
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code ferrell-code added the C-enhancement Category: An issue proposing an enhancement or a PR with one label May 20, 2024
@ferrell-code ferrell-code merged commit 95e5e27 into manta May 22, 2024
31 of 41 checks passed
@ferrell-code ferrell-code deleted the release-v4.7.0 branch May 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-release Related to a release L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants