Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manta-PC] Updrading dependencies to v0.9.10 #195

Merged
merged 8 commits into from Sep 27, 2021

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Sep 17, 2021

Description

closes: #196

Polkadot Changes:

Substrate Changes:

Cumulus Changes:

statemine diffs between:

  • fd80849dde5c209c20a996cfcc5aaacd4666dcbe -> 0.9.9
  • fa116cfbfb470a8114fc02f9d2e3c0a5ab6c7193 -> 0.9.10

Performed tests with local calamari-local and calamari-testnet networks:

  • Does key injection script work (only for calamari-testnet)
  • Check block production
  • Sudo system.setCode upgrade
  • Force transfer balances
  • Pass sudo to multi-sig account
  • Upgrade with authorizeUpgrade + enactAuthorized
  • Check average block time is ~12 seconds
  • Check dropping and reconnecting a collator

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or manta-pc) with right title (start with [Manta] or [Manta-PC]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.

@ghzlatarev ghzlatarev self-assigned this Sep 17, 2021
@ghzlatarev ghzlatarev marked this pull request as ready for review September 20, 2021 19:26
@ghzlatarev
Copy link
Contributor Author

@stechu reverted the chain_spec version to 1. We will need a runtime upgrade after Kusama has done one, as per what Basti said.

@ghzlatarev
Copy link
Contributor Author

@stechu triggered the integration tests with a fake tag namev0.0.0-polkadot-v0.9.9-tests
We will need a real one when you merge this.

@stechu
Copy link
Contributor

stechu commented Sep 20, 2021

@stechu reverted the chain_spec version to 1. We will need a runtime upgrade after Kusama has done one, as per what Basti said.

I am not sure whether this alone will do that job. In the code, you still rely on the new version of XCM. I would suggest you to roll-back the XCM related code, i.e. still use v0.

@stechu
Copy link
Contributor

stechu commented Sep 20, 2021

@ghzlatarev As we discussed, can you provide the list of upstream changes that we can review against to?

@ghzlatarev
Copy link
Contributor Author

@ghzlatarev As we discussed, can you provide the list of upstream changes that we can review against to?

My bad included it in the description.
polkadot -> release-v0.9.10 -> https://github.com/paritytech/polkadot/releases/tag/v0.9.10-rc2
Cumulus diff between:
fd80849dde5c209c20a996cfcc5aaacd4666dcbe -> 0.9.9
fa116cfbfb470a8114fc02f9d2e3c0a5ab6c7193 -> 0.9.10

@ghzlatarev
Copy link
Contributor Author

@stechu reverted the chain_spec version to 1. We will need a runtime upgrade after Kusama has done one, as per what Basti said.

I am not sure whether this alone will do that job. In the code, you still rely on the new version of XCM. I would suggest you to roll-back the XCM related code, i.e. still use v0.

I don't seem to be able to make the runtime code compile without using v1 folder yet.

@Dengjianping
Copy link
Contributor

@stechu Do you think we need to bump the version as well? From 3.0.1 to 3.0.2.

@stechu
Copy link
Contributor

stechu commented Sep 23, 2021

@stechu Do you think we need to bump the version as well? From 3.0.1 to 3.0.2.

We should.

@stechu
Copy link
Contributor

stechu commented Sep 23, 2021

@stechu reverted the chain_spec version to 1. We will need a runtime upgrade after Kusama has done one, as per what Basti said.

I am not sure whether this alone will do that job. In the code, you still rely on the new version of XCM. I would suggest you to roll-back the XCM related code, i.e. still use v0.

I don't seem to be able to make the runtime code compile without using v1 folder yet.

@stechu stechu closed this Sep 23, 2021
@stechu
Copy link
Contributor

stechu commented Sep 23, 2021

@ghzlatarev As we discussed, can you provide the list of upstream changes that we can review against to?

My bad included it in the description.
polkadot -> release-v0.9.10 -> https://github.com/paritytech/polkadot/releases/tag/v0.9.10-rc2
Cumulus diff between:
fd80849dde5c209c20a996cfcc5aaacd4666dcbe -> 0.9.9
fa116cfbfb470a8114fc02f9d2e3c0a5ab6c7193 -> 0.9.10

@ghzlatarev Here is an example of how to properly description a upstream upgrade:

Polkadot Changes:

The list of polkadot changes

Overview PR:
paritytech/polkadot#3763

Please do the same for Cumulus and Substrate.

@stechu stechu reopened this Sep 23, 2021
@ghzlatarev
Copy link
Contributor Author

@stechu Do you think we need to bump the version as well? From 3.0.1 to 3.0.2.

We should.

Done.

Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dengjianping Dengjianping merged commit a11ba65 into manta-pc Sep 27, 2021
@Dengjianping Dengjianping deleted the ghzlatarev/polkadot-v0.9.10 branch September 27, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies to v0.9.10
3 participants