This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
properly gate sanity check #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
wpank
approved these changes
Aug 21, 2021
GopherJ
pushed a commit
to parallel-finance/polkadot
that referenced
this pull request
Aug 23, 2021
bkchr
pushed a commit
that referenced
this pull request
Aug 23, 2021
* Bypass chain-selection subsystem until disputes are enabled. (#3676) * cleanup of rob's patch * depend on feature disputes, both lag and query * typo * make it work TODO move the fallback into selection * option * Update node/service/src/relay_chain_selection.rs * remove trait implementation and fix errors * hotfix: tests * fmt * remove unused trait * make pub(crate) for test * disable tests with disputed blocks * Fix warnings Co-authored-by: Robert Habermeier <rphmeier@gmail.com> Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com> * properly gate sanity check (#3684) Co-authored-by: Bernhard Schuster <bernhard@ahoi.io> Co-authored-by: Robert Habermeier <rphmeier@gmail.com> Co-authored-by: Lldenaurois <Ljdenaurois@gmail.com>
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only relevant when passing data through to disputes, and is noisy due to #3678