Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified client for Manta and Calamari #245

Merged
merged 11 commits into from
Nov 5, 2021
Merged

Unified client for Manta and Calamari #245

merged 11 commits into from
Nov 5, 2021

Conversation

stechu
Copy link
Collaborator

@stechu stechu commented Nov 4, 2021

Description

closes: #232

  • Unify Manta/Calamari Client
  • Change CI accordingly
  • fix CI client version bug
  • update docker file generation

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or manta-pc) with right title (start with [Manta] or [Manta-PC]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics

@stechu stechu marked this pull request as draft November 4, 2021 02:02
@stechu stechu marked this pull request as ready for review November 4, 2021 10:48
@Dengjianping
Copy link
Contributor

Dengjianping commented Nov 4, 2021

Should our manta runtime be renamed from manta-pc to manta?

spec_name: create_runtime_str!("manta-pc"),

But if we change this name, I'm not sure whether we need to submit a pr to polkadot-js.
We should take some time on testing with frontend, ensure polkadot-js can work well with our configuration.

BTW, what's the size of new client binary?

@Dengjianping
Copy link
Contributor

Please rename that dockerfile, because we're going to unify the binary, there's no need to keep that name of dockerfile.

@stechu
Copy link
Collaborator Author

stechu commented Nov 4, 2021

Please rename that dockerfile, because we're going to unify the binary, there's no need to keep that name of dockerfile.

I think we still need two docker file? since the genesis are different?

@Dengjianping
Copy link
Contributor

Please rename that dockerfile, because we're going to unify the binary, there's no need to keep that name of dockerfile.

I think we still need two docker file? since the genesis are different?

Maybe we can get what suggestion from devops' perspective.

Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stechu stechu merged commit b602df2 into manta-pc Nov 5, 2021
@stechu stechu deleted the unified-client branch June 23, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unified Manta and Calamari Client
3 participants