-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Update PULL_REQUEST_TEMPLATE.md #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Reif <garandor@manta.network>
Signed-off-by: Adam Reif <garandor@manta.network>
Garandor
added
C-discussion
Category: Discussion or questions that don't represent real issues
A-development
Area: Development Resources and Upgrades
C-enhancement
Category: An issue proposing an enhancement or a PR with one
and removed
C-discussion
Category: Discussion or questions that don't represent real issues
labels
Jul 12, 2022
Signed-off-by: Adam Reif garandor@manta.network Signed-off-by: Adam Reif <garandor@manta.network>
Garandor
commented
Jul 27, 2022
ghzlatarev
reviewed
Jul 28, 2022
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
added
L-changed
Log: Issues and PRs related to changes
and removed
DO-NOT-MERGE
Labels a PR that should not be merged
labels
Sep 8, 2022
Dengjianping
approved these changes
Sep 8, 2022
ghzlatarev
added
the
A-calamari
Area: Issues and PRs related to the Calamari Runtime
label
Sep 8, 2022
ghzlatarev
reviewed
Sep 8, 2022
flame4
approved these changes
Sep 9, 2022
Garandor
removed
the
A-calamari
Area: Issues and PRs related to the Calamari Runtime
label
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-development
Area: Development Resources and Upgrades
C-enhancement
Category: An issue proposing an enhancement or a PR with one
E-minutes
few minutes of effort, trivial change
L-changed
Log: Issues and PRs related to changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Reif garandor@manta.network
Description
I would like everyone to start using the labelling system on our issues and PRs.
Later (#661 ) this'll enable us to auto-generate the Changelog.
This is an RFC, pls discuss if we should any more mandatory steps @ghzlatarev @Dengjianping
Two goals:
relates to: #600
Before we can merge this PR, make sure that all the following items have been
checked off.
L-
group against this PRA-
and one label from theC-
group against either this PR or its associated issueFiles changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updated