-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Adding diff result to changelog verification workflow #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apokalip
force-pushed
the
release-v0.0.0
branch
5 times, most recently
from
October 14, 2022 14:23
5baa1ef
to
386b10f
Compare
Signed-off-by: Apokalip <simeon@manta.network>
Apokalip
force-pushed
the
release-v0.0.0
branch
from
October 14, 2022 14:58
386b10f
to
72befab
Compare
Apokalip
requested review from
Garandor,
Dengjianping,
flame4,
ghzlatarev and
zqhxuyuan
October 14, 2022 15:00
Signed-off-by: Apokalip <simeon@manta.network>
Signed-off-by: Apokalip <simeon@manta.network>
Apokalip
added
C-enhancement
Category: An issue proposing an enhancement or a PR with one
A-ci
Area: Continuous Integration
L-skip
Log: Will be skipped on changelog generation
labels
Oct 14, 2022
Signed-off-by: Apokalip <simeon@manta.network>
Signed-off-by: Apokalip <simeon@manta.network>
Signed-off-by: Apokalip <simeon@manta.network>
Garandor
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ferrell-code
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, that diff is much more readable
Garandor
added
L-changed
Log: Issues and PRs related to changes
and removed
L-skip
Log: Will be skipped on changelog generation
L-changed
Log: Issues and PRs related to changes
labels
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ci
Area: Continuous Integration
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-skip
Log: Will be skipped on changelog generation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Apokalip simeon@manta.network
Description
closes: #843
release: Manta-Network/dev-tools#13
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updated