Release v3.4.3 (second attempt)

[Garandor]

Signed-off-by: Adam Reif Garandor@manta.network

Diff to last release: v3.4.2...release-v3.4.3

Description

relates to #853

---

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

• Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
• Added one label out of the L- group to this PR
• Added one or more labels from the A- and C- groups to this PR
• Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
• This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
• Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

• If adding functionality, write unit tests!
• If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
• If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
• If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
• If runtime changes, need to update the version numbers properly:
  • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
  • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
  • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
  • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
• Verify benchmarks & weights have been updated for any modified runtime logics

[ferrell-code]

Some of the crate versions are still 3.4.2 or 3.4.0. Not sure if we bump all of them, we don't necessarily have to sync all of them to runtime versions, but figured I would point it out

example:

Manta/primitives/manta/Cargo.toml

Line 8 in 79b9036

version = '3.4.2'

[Garandor]

Some of the crate versions are still 3.4.2 or 3.4.0. Not sure if we bump all of them, we don't necessarily have to sync all of them to runtime versions, but figured I would point it out

example:

Manta/primitives/manta/Cargo.toml

Line 8 in 79b9036

version = '3.4.2'

Thanks for checking these, looks like I didn't catch all with search-and-replace.
I think I got em all now - except manta-pay which will stay on v0.4.0 until #747 is merged