Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

++xcconfigs #227

Merged
merged 3 commits into from

3 participants

@robb
Owner

Closes #221

robb added some commits
@robb robb ++xcconfigs 4b7cd96
@robb robb Remove static qualifier from error codes
Otherwise Xcode considers them unused variables per
-Wunused-const-variable
24a593d
@jspahrsummers jspahrsummers merged commit bc2a670 into master
@jspahrsummers jspahrsummers deleted the bump-xcconfigs branch
@JaviSoto

This one IS used, the other one isn't (so can be removed?)

Depends on the build configuration.

@JaviSoto

If you don't make them static, they're extern, which means they're visible outside their own file's unit.

There's nothing wrong with that here. They use prefixed names, so they're not going to conflict with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 1, 2014
  1. @robb

    ++xcconfigs

    robb authored
  2. @robb

    Remove static qualifier from error codes

    robb authored
    Otherwise Xcode considers them unused variables per
    -Wunused-const-variable
Commits on Feb 2, 2014
  1. @robb

    Remove unnecessary error code

    robb authored
This page is out of date. Refresh to see the latest.
2  Configuration
@@ -1 +1 @@
-Subproject commit 406c5a248491de20421d4935ac5979eba0886996
+Subproject commit 539f059757b2e06417fcc3da90bbbe807137985e
View
2  Mantle/MTLJSONAdapter.m
@@ -15,7 +15,7 @@
const NSInteger MTLJSONAdapterErrorInvalidJSONDictionary = 3;
// An exception was thrown and caught.
-static const NSInteger MTLJSONAdapterErrorExceptionThrown = 1;
+const NSInteger MTLJSONAdapterErrorExceptionThrown = 1;
// Associated with the NSException that was caught.
static NSString * const MTLJSONAdapterThrownExceptionErrorKey = @"MTLJSONAdapterThrownException";
View
3  Mantle/MTLManagedObjectAdapter.m
@@ -34,9 +34,6 @@ static id performInContext(NSManagedObjectContext *context, id (^block)(void)) {
return result;
}
-// An exception was thrown and caught.
-static const NSInteger MTLManagedObjectAdapterErrorExceptionThrown = 1;
-
@interface MTLManagedObjectAdapter ()
// The MTLModel subclass being serialized or deserialized.
Something went wrong with that request. Please try again.