Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment system to posts #45

Closed
rygos opened this issue Nov 6, 2019 · 8 comments
Closed

Comment system to posts #45

rygos opened this issue Nov 6, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@rygos
Copy link

rygos commented Nov 6, 2019

Please make it possible to allow comments (only for Registered Users) to a Link or Image or Story.

@MarceauKa MarceauKa added enhancement New feature or request question Further information is requested labels Nov 6, 2019
@MarceauKa
Copy link
Owner

Yep, it can be a good idea but need a lot a changes to allow users to register. Maybe a public comment system with grey-listing. Example: you post a comment with username + email + comment. The comment is not displayed and need to be moderated. Once you have been moderated once, your comments are now auto-moderated.

@rygos
Copy link
Author

rygos commented Nov 6, 2019

Good point. I forget about registration. What about Disqus integration? For this, no registration for shaarli is needed.

@MarceauKa
Copy link
Owner

Nope, the philosophy of Laravel Shaarli is to be third-party free. This is why there's no CDN, no tracker, no cool web services (such Google Fonts, etc).

What do you think about my comment integration?

@MarceauKa MarceauKa changed the title Comments for Contentpostings Comment system to posts Nov 7, 2019
@rygos
Copy link
Author

rygos commented Nov 7, 2019

I would also prefer to have my own system. I think moderation is a good thing in itself, but it would also require some effort in the long run. Automatic moderation would be cool, but in the variant suggested by you, it might be a security problem. Everyone can enter a mail+username combination that has already been moderated.

I suppose it would be better to eventually allow a registration where only one moderation is required.
Guests should always. When commenting as a guest, a captcha would also be worth considering.

@MarceauKa
Copy link
Owner

In my suggestion, email address of the user who's commenting is hidden. So nobody can use the username and the email of an already moderated user. I think it can be a good idea to implements comment system like this and in the future, allowing user to register.

@wyred
Copy link
Contributor

wyred commented Nov 8, 2019

Laravel Shaarli is a self-hosted platform to keep and share your content: web links, posts, passwords and pictures.

I disagree with having a comment system. I would use a blog if I wanted comments.

But if the decision is made to implement a comment system, please keep it disabled by default. :)

@virtadpt
Copy link

virtadpt commented Nov 8, 2019

Seconded. I pick stuff that doesn't have comment support deliberately. I don't like the idea of the new iteration of Shaarli having comment support, but if it happens, please make it possible to disable it.

@MarceauKa MarceauKa added next version Something for the next version of the project and removed question Further information is requested labels Nov 20, 2019
@MarceauKa
Copy link
Owner

Released in 1.2.33

@MarceauKa MarceauKa removed the next version Something for the next version of the project label Nov 24, 2019
@MarceauKa MarceauKa self-assigned this Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants