forked from SFML/SFML
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
9fac5d7
commit a92b913
Showing
2 changed files
with
34 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a92b913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been a while since I've done some DSP, but wouldn't you determine the max scaling value over the whole track first rather then determining it "on the fly" while scaling already? E.g. the values in raw could be
[5, 10, 15]
you'd scale the first value using5
, the second one using10
, etc., resulting in[32767.0, 32767.0, 32767]
, because the maximum changes every iteration? Or am I missing something right now and this is working differently and/or intentionally that way?a92b913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a92b913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay, so it's essentially a "lesser evil" approach? Cause it should work fine once the maximum has been reached.
a92b913
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.