Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update octicon version #1639

Closed
damithc opened this issue Jul 27, 2021 · 4 comments · Fixed by #1652
Closed

Update octicon version #1639

damithc opened this issue Jul 27, 2021 · 4 comments · Fixed by #1652

Comments

@damithc
Copy link
Contributor

damithc commented Jul 27, 2021

Some of these octicons don't seem to be available (or looks different) e.g., https://primer.style/octicons/file-diff-16

Perhaps we need to update our octicon version?

@wxwxwxwx9
Copy link
Contributor

Our version is indeed rather outdated 😓

@ong6
Copy link
Contributor

ong6 commented Aug 11, 2021

Hi after doing some light testing, it seems the fix for this is simply running lerna add @primer/octicons packages/core not sure if this is worth a individual PR? Should I add it to my PR at #1647 ?

@wxwxwxwx9
Copy link
Contributor

wxwxwxwx9 commented Aug 11, 2021

@ong6 Hi there! Thanks for taking a look at this.

I think it will be better if we create a new PR for this :-)

It will be more in line with the guideline set out below.

https://se-education.org/guides/guidelines/PRs.html

@ong6
Copy link
Contributor

ong6 commented Aug 11, 2021

@wxwxwxwx9 Thanks for the clarification! Was not sure if a one line update warranted a PR XD

This was referenced Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants