Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI test for pull requests against all branches #1876

Closed
1 task done
jonahtanjz opened this issue Apr 5, 2022 · 2 comments · Fixed by #1878
Closed
1 task done

Run CI test for pull requests against all branches #1876

jonahtanjz opened this issue Apr 5, 2022 · 2 comments · Fixed by #1878

Comments

@jonahtanjz
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Any related issues?

No response

What is the area that this feature belongs to?

DevOps

Is your feature request related to a problem? Please describe.

Currently only PRs against the master branch will trigger the CI test workflow. For instance #1834 does not have any CI test when merging to the bootstrap development branch.

Describe the solution you'd like

Trigger CI test for all base branches in MarkBind. This will be useful for hot fix branches as well.

Describe alternatives you've considered

No response

Additional context

No response

@tlylt
Copy link
Contributor

tlylt commented Apr 5, 2022

Will it be possible that PRs to a non-master branch do not pass the CI checks for some legitimate reason? Perhaps because the changes are drastic and progressive, some test cases are ok to fail initially but will be fixed later on. If such cases are valid, then perhaps the CI runs on those PRs may not be strictly necessary (in a sense that it does not give any good information about the quality of this PR)

@jonahtanjz
Copy link
Contributor Author

Will it be possible that PRs to a non-master branch do not pass the CI checks for some legitimate reason?

Agree there could be such cases but I think these can be exceptions (i.e continue to merge to dev branch even if CI is failing).

If such cases are valid, then perhaps the CI runs on those PRs may not be strictly necessary (in a sense that it does not give any good information about the quality of this PR)

I think having CI test on PRs to all branches will be useful in general. For PRs that are progressive, if the tests are meant to be updated together, it would be good to pick up failing tests earlier instead of only seeing it in the final merge to master. For hotfix branches, it would definitely be needed since it is going to be used for releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants