Documentation for Implement no-* attributes for <box> #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review |
yamgent
reviewed
Feb 16, 2020
| @@ -264,6 +296,9 @@ header <hr style="margin-top:0.2rem; margin-bottom:0" /> <small>heading <br> (de | |||
| type | `String` | `'none'` | Supports: `info`, `warning`, `success`, `important`, `wrong`, `tip`, `definition`, or empty for default. | |||
| light | `Boolean` | `false` | Uses a light color scheme for the box. | |||
| seamless | `Boolean` | `false` | Uses a seamless style for the box. If `light` is specified, this style will not be activated. | |||
| no-border | `Boolean` | `false` | Removes border, except if styled by `border-color` or `border-left-color`. | |||
| no-backgound | `Boolean` | `false` | Removes background, except if styled by `backgound-color` option. | |||
| no-icon | `Boolean` | `false` | Removes icon, except if icon is displayed via `icon` option. | |||
There was a problem hiding this comment.
The attributes list should ideally be sorted. Noted that we have some of the entries being off unfortunately. Perhaps we can move these attributes to above "type" to make it less messy?
There was a problem hiding this comment.
I see. I assumed we were separating String options from the Boolean options. I'll move it above "type" for now.
|
Noted regarding not updating minified vue-strap. |
nbriannl
changed the title
nbriannl
force-pushed
the
box-no-attr
branch
from
0ff114d
to
ee86ced
Compare
nbriannl
changed the title
|
#118 has been merged. Ready for (re)review. |
nbriannl
changed the title
nbriannl
changed the title
nbriannl
force-pushed
the
box-no-attr
branch
from
337a0a5
to
ee86ced
Compare
nbriannl
force-pushed
the
box-no-attr
branch
from
ee86ced
to
0d916d9
Compare
yamgent
approved these changes
Mar 3, 2020
yamgent
added
the
pr.DocsUpdate 📃
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 7, 2020
…nvert-to-code-block * 'master' of https://github.com/MarkBind/markbind: Allow changing parameter properties (MarkBind#1075) Custom timezone for built-in timestamp (MarkBind#1073) Fix reload inconsistency when updating frontmatter (MarkBind#1068) Implement an api to ignore content in certain tags (MarkBind#1047) Enable AppVeyor CI (MarkBind#1040) Add heading and line highlighting to code blocks (MarkBind#1034) Add dividers and fix bug in siteNav (MarkBind#1063) Fixed navbar no longer covers modals (MarkBind#1070) Add copy code-block plugin (MarkBind#1043) Render plugins on dynamic resources (MarkBind#1051) Documentation for Implement no-* attributes for <box> (MarkBind#1042) Migrate to bootstrap-vue popovers (MarkBind#1033) Refactor preprocess and url processing functions (MarkBind#1026) Add pageNav to Using Plugins Page (MarkBind#1062) # Conflicts: # docs/userGuide/syntax/siteNavigationMenus.mbdf
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 9, 2020
* 'master' of https://github.com/MarkBind/markbind: 2.12.0 Update outdated test files Update vue-strap version to v2.0.1-markbind.37 Fix refactor to processDynamicResources (MarkBind#1092) Implement lazy page building for markbind serve (MarkBind#1038) Add warnings for conflicting/deprecated component attribs (MarkBind#1057) Allow changing parameter properties (MarkBind#1075) Custom timezone for built-in timestamp (MarkBind#1073) Fix reload inconsistency when updating frontmatter (MarkBind#1068) Implement an api to ignore content in certain tags (MarkBind#1047) Enable AppVeyor CI (MarkBind#1040) Add heading and line highlighting to code blocks (MarkBind#1034) Add dividers and fix bug in siteNav (MarkBind#1063) Fixed navbar no longer covers modals (MarkBind#1070) Add copy code-block plugin (MarkBind#1043) Render plugins on dynamic resources (MarkBind#1051) Documentation for Implement no-* attributes for <box> (MarkBind#1042) Migrate to bootstrap-vue popovers (MarkBind#1033) Refactor preprocess and url processing functions (MarkBind#1026) Add pageNav to Using Plugins Page (MarkBind#1062)
|
Works in production. Good work @nbriannl and reviewers 👍 |
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Enhancement to an existing feature
Fixes #978
Requires MarkBind/vue-strap#129
What is the rationale for this request?
What changes did you make? (Give an overview)
Corresponding documentation update to MarkBind/vue-strap#129
Provide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Implement no-* attributes for box