Fix reload inconsistency when updating frontmatter

[Parcly-Taxel]

What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Bug fix

What is the rationale for this request?
See proposed commit message below. This fixes #1001.

What changes did you make? (Give an overview)
The frontmatter files for the site templates are populated.

Is there anything you'd like reviewers to focus on?
This is just #1035 reopened, with proper branch management on my part, following advice from @ang-zeyu.

Testing instructions:
See topic opener for #1001.

Proposed commit message: (wrap lines at 72 characters)
Fix reload inconsistency when updating frontmatter

The header, footer and navigation frontmatter for the minimal and
default site templates are empty. This causes inconsistent reloading
when the frontmatter is changed (#1001). Here we populate said
frontmatter.

[crphang]

@Parcly-Taxel could we also add this to the collectAllPageSections?

Page.prototype.collectAllPageSections = function () {
+ this.pageSectionsHtml = {}; // This resets the pageSectionsHTML whenever we collect.
  this.collectPageSection('header');
  this.collectPageSection(`#${SITE_NAV_ID}`);
  this.collectPageSection('footer');
};

This ensures that each reload always reset the pageSections and reduce the dependency on how templates are created which could potentially be crowd-sourced. While you're at it, could you also add <header> and <footer> to minimal template?

Thanks for your contribution!

[Parcly-Taxel]

could we also add this to the collectAllPageSections?

Page.prototype.collectAllPageSections = function () {
+ this.pageSectionsHtml = {}; // This resets the pageSectionsHTML whenever we collect.
  this.collectPageSection('header');
  this.collectPageSection(`#${SITE_NAV_ID}`);
  this.collectPageSection('footer');
};

@crphang done, but @ang-zeyu said in #1035 to "go the other way", i.e. "add <header> and <footer> to minimal template", which I had already done before closing the original PR.

[ang-zeyu]

@crphang done, but @ang-zeyu said in #1035 to "go the other way", i.e. "add <header> and <footer> to minimal template", which I had already done before closing the original PR.

You could do both #1001 (comment) :)

The fix I suggested was merely to remove {{ timestamp }} from the footer(s), which would cause your tests to fail irregardless
And also to add the changes to the minimal template for consistency since the default template is also getting "the other fix". ( markbind has 2 templates )

[Parcly-Taxel]

You could do both #1001 (comment) :)

The fix I suggested was merely to remove {{ timestamp }} from the footer(s), which would cause your tests to fail irregardless
And also to add the changes to the minimal template for consistency since the default template is also getting "the other fix". ( markbind has 2 templates )

@ang-zeyu yes, can we merge this now, since I have done both?

[ang-zeyu]

yes, can we merge this now, since I have done both?

Looks good to me 👍

I don't have merging powers here though, you'd have to wait for a maintainer to merge this in!

[Parcly-Taxel]

yes, can we merge this now, since I have done both?

Looks good to me +1

I don't have merging powers here though, you'd have to wait for a maintainer to merge this in!

Can't you approve it first?