Fix refactor to processDynamicResources #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ang-zeyu
added
the
p.Urgent
openorclose
requested changes
Mar 7, 2020
src/lib/markbind/src/parser.js
Outdated
| @@ -211,6 +211,9 @@ class Parser { | |||
|
|
|||
| $('img, pic, thumbnail').each(function () { | |||
| const elem = $(this); | |||
| if (elem[0].name === 'thumbnail' && elem.attr('src') === undefined) { | |||
There was a problem hiding this comment.
Suggested change
| if (elem[0].name === 'thumbnail' && elem.attr('src') === undefined) { | |
| if (elem.attr('src') === undefined) { |
Should we do this then?
Even though pics and imgs must have the src attribute, the author could still forget to include them.
ang-zeyu
force-pushed
the
fix-dynamic-resources-refactor
branch
from
ea7a176
to
5013906
Compare
ang-zeyu
changed the title
openorclose
approved these changes
Mar 7, 2020
yamgent
approved these changes
Mar 8, 2020
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Mar 9, 2020
* 'master' of https://github.com/MarkBind/markbind: 2.12.0 Update outdated test files Update vue-strap version to v2.0.1-markbind.37 Fix refactor to processDynamicResources (MarkBind#1092) Implement lazy page building for markbind serve (MarkBind#1038) Add warnings for conflicting/deprecated component attribs (MarkBind#1057) Allow changing parameter properties (MarkBind#1075) Custom timezone for built-in timestamp (MarkBind#1073) Fix reload inconsistency when updating frontmatter (MarkBind#1068) Implement an api to ignore content in certain tags (MarkBind#1047) Enable AppVeyor CI (MarkBind#1040) Add heading and line highlighting to code blocks (MarkBind#1034) Add dividers and fix bug in siteNav (MarkBind#1063) Fixed navbar no longer covers modals (MarkBind#1070) Add copy code-block plugin (MarkBind#1043) Render plugins on dynamic resources (MarkBind#1051) Documentation for Implement no-* attributes for <box> (MarkBind#1042) Migrate to bootstrap-vue popovers (MarkBind#1033) Refactor preprocess and url processing functions (MarkBind#1026) Add pageNav to Using Plugins Page (MarkBind#1062)
marvinchin
pushed a commit
that referenced
this pull request
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
Apologies, missed this out while reviewing #1075.
See #1075 (comment) for original code
CI passes on travis because
ensurePosixonly runs ifpath.sep !== /( non-unix ).Otherwise
undefinedis passed to it which causes tests to fail. This is one such case #1040 could be really usefulWhat changes did you make? (Give an overview)
Reintroduced a
undefinedcheck for the the element'ssrcbefore passing it toutils.ensurePosixto prevent said error.Proposed commit message: (wrap lines at 72 characters)
Fix refactor to processDynamicResources