-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deploy error and deploy test case #2346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @WillCWX for working on this PR. I have a few comments. Main issues:
- Could you take another look at the original PR and the changes made? https://github.com/MarkBind/markbind/pull/2270/files
- I'm not sure why some changes (deletion, type assertions) that were made are not transferred back in this PR. I have pointed out a few places but I realized they are not done properly. If you have any concerns or comments as to why those are not necessary changes, please indicate for discussion.
- After everything is done, will need to re-organize into 2 commits as specified in the DG, one for rename, and one for migration. (Please rebase first as well)
I've compared the current migration with the previous PR and also the v5.0.0 file and made the changes accordingly. As requested, I've removed the comments noted and also all the |
If its ok, I'll merge with master to update the branch and then rebase into two commits as mentioned in the docs. |
Oh wait sorry let me do a final check |
👍 @WillCWX can organize and will merge after that's done |
Site/index.ts was previously bugged and caused errors with markbind deploy. As a stopgap measure, Site/index.ts was re-adapted back to JS. The bug has now been identified along with a fix, however, Site/index will need to be remigrated back to TS. The false negative test case in deploy has also been identifed and will be fixed as well. Let's remigrate Site/index to TS, fix the deploy option that caused the markbind deploy bug and also fix the negative test case that failed to detect the bug. Migration was made according to the original migration PR and the latest v5.0.0.
What is the purpose of this pull request?
Close #2333
Related to #2331
Overview of changes:
Site/index.js
toTypeScript
again.options.remote
to bedefaultOptionConfig.remote
instead of''
options.remote = defaultDeployConfig.remote
ingetDepUrl
Anything you'd like to highlight/discuss:
No
Testing instructions:
set up a test repo that with github pages
run markbind deploy
Proposed commit message: (wrap lines at 72 characters)
Fix deploy error and deploy test case
Checklist: ☑️