Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy error and deploy test case #2346

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Fix deploy error and deploy test case #2346

merged 2 commits into from
Jul 30, 2023

Commits on Jul 30, 2023

  1. Rename Site/index.js to TypeScript

    @WillCWX
    WillCWX committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    de19656 View commit details
    Browse the repository at this point in the history

  2. Adapt Site/index to TypeScript 

    Site/index.ts was previously bugged and caused errors with markbind
deploy. As a stopgap measure, Site/index.ts was re-adapted back to JS.

The bug has now been identified along with a fix, however,
Site/index will need to be remigrated back to TS. The false negative
test case in deploy has also been identifed and will be fixed as well.

Let's remigrate Site/index to TS, fix the deploy option that caused
the markbind deploy bug and also fix the negative test case that failed
to detect the bug.

Migration was made according to the original migration PR and the latest
v5.0.0.
    @WillCWX
    WillCWX committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    da60c0d View commit details
    Browse the repository at this point in the history