Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 'JUNCTION_DEVIATION_MM' - not declared (module\configuration_store) #15514

Closed
kubik256 opened this issue Oct 11, 2019 · 5 comments
Closed

Comments

@kubik256
Copy link

kubik256 commented Oct 11, 2019

Hello,
I have strange error today while compilling bugfix 2.0.x (actual ver. from 11. ‎Oct ‎2019, ‏‎9:29:21):

Compiling .pio\build\STM32F103RC_bigtree\src\src\module\motion.cpp.o
Marlin\src\module\configuration_store.cpp: In static member function 'static void MarlinSettings::reset()':
Marlin\src\module\configuration_store.cpp:2239:43: error: 'JUNCTION_DEVIATION_MM' was not declared in this scope
     planner.junction_deviation_mm = float(JUNCTION_DEVIATION_MM);
                                           ^~~~~~~~~~~~~~~~~~~~~
Marlin\src\module\configuration_store.cpp:2239:43: note: suggested alternative: 'ENC_DEVIATION_t'
     planner.junction_deviation_mm = float(JUNCTION_DEVIATION_MM);
                                           ^~~~~~~~~~~~~~~~~~~~~
                                           ENC_DEVIATION_t
*** [.pio\build\STM32F103RC_bigtree\src\src\module\configuration_store.cpp.o] Error 1
================================================================================================= [FAILED] Took 168.51 seconds =================================================================================================

Environment              Status    Duration
-----------------------  --------  ------------
megaatmega2560           IGNORED
megaatmega1280           IGNORED
at90usb1286_cdc          IGNORED
at90usb1286_dfu          IGNORED
DUE                      IGNORED
DUE_USB                  IGNORED
DUE_debug                IGNORED
LPC1768                  IGNORED
LPC1769                  IGNORED
melzi                    IGNORED
melzi_optiboot           IGNORED
rambo                    IGNORED
sanguino_atmega644p      IGNORED
sanguino_atmega1284p     IGNORED
STM32F103RE              IGNORED
STM32F103RC_fysetc       IGNORED
STM32F103RC_bigtree      FAILED    00:02:48.508
STM32F103RC_bigtree_USB  IGNORED
STM32F4                  IGNORED
STM32F7                  IGNORED
ARMED                    IGNORED
STM32F103VE_longer       IGNORED
mks_robin                IGNORED
mks_robin_lite           IGNORED
mks_robin_mini           IGNORED
mks_robin_nano           IGNORED
jgaurora_a5s_a1          IGNORED
STM32F407VE_black        IGNORED
BIGTREE_SKR_PRO          IGNORED
BIGTREE_BTT002           IGNORED
teensy31                 IGNORED
teensy35                 IGNORED
STM32F103CB_malyan       IGNORED
esp32                    IGNORED
fysetc_f6_13             IGNORED
linux_native             IGNORED
SAMD51_grandcentral_m4   IGNORED
include_tree             IGNORED
============================================================================================ 1 failed, 0 succeeded in 00:02:48.508 ============================================================================================  
The terminal process terminated with exit code: 1

Same Configuration.h and Configuration_ADV.h has been successfully compiled at 4th October 2019 at 12:00 AM.

Thank you, BR ;)

config_files.zip

@kubik256
Copy link
Author

Enabling JUNCTION_DEVIATION and define JUNCTION_DEVIATION_MM in Configuration.h also doesn't solve the problem:(

In file included from Marlin\src\HAL\HAL_STM32F1\../../inc/MarlinConfig.h:38:0,
                 from Marlin\src\HAL\HAL_STM32F1\HAL_SPI.cpp:35:
Marlin\src\HAL\HAL_STM32F1\../../inc/SanityCheck.h:408:4: error: #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
   #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
    ^~~~~
In file included from Marlin\src\HAL\HAL_STM32F1\../../inc/MarlinConfig.h:38:0,
                 from Marlin\src\HAL\HAL_STM32F1\HAL.cpp:31:
Marlin\src\HAL\HAL_STM32F1\../../inc/SanityCheck.h:408:4: error: #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
   #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
    ^~~~~
In file included from Marlin\src\HAL\HAL_STM32F1\../../inc/MarlinConfig.h:38:0,
                 from Marlin\src\HAL\HAL_STM32F1\Servo.cpp:26:
Marlin\src\HAL\HAL_STM32F1\../../inc/SanityCheck.h:408:4: error: #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
   #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
    ^~~~~
In file included from e:\marlin-bugfix-2.0.x\marlin\src\inc\marlinconfig.h:38:0,
                 from Marlin\src\HAL\HAL_STM32F1\dogm\u8g_com_stm32duino_fsmc.cpp:29:
e:\marlin-bugfix-2.0.x\marlin\src\inc\SanityCheck.h:408:4: error: #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
   #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."
    ^~~~~
*** [.pio\build\STM32F103RC_bigtree\src\src\HAL\HAL_STM32F1\HAL.cpp.o] Error 1
*** [.pio\build\STM32F103RC_bigtree\src\src\HAL\HAL_STM32F1\HAL_SPI.cpp.o] Error 1
*** [.pio\build\STM32F103RC_bigtree\src\src\HAL\HAL_STM32F1\Servo.cpp.o] Error 1
*** [.pio\build\STM32F103RC_bigtree\src\src\HAL\HAL_STM32F1\dogm\u8g_com_stm32duino_fsmc.cpp.o] Error 1
================================================================================================== [FAILED] Took 9.07 seconds ==================================================================================================

@GMagician
Copy link
Contributor

I think you have to update your cnf file...

error: #error "JUNCTION_DEVIATION is no longer required. (See CLASSIC_JERK). Please remove it from Configuration.h."

Now you have to define CLASSIC_JERK for old stile otherwise junction is enabled and mm has to be present of course

@kubik256
Copy link
Author

THANKS! Old configuration from example or stock one from manufacturer doesn't work anymore.
Sucessfully compiled with this:

//#define JUNCTION_DEVIATION
//#if ENABLED(JUNCTION_DEVIATION)
  #define JUNCTION_DEVIATION_MM 0.065  // (mm) Distance from real junction edge
//#endif

Whole JUNCTION_DEVIATION block and IF clausule must be commented out ;)

@thisiskeithb
Copy link
Member

thisiskeithb commented Oct 11, 2019

Whole JUNCTION_DEVIATION block and IF clausule must be commented out ;)

I'd recommend comparing your Configuration.h with the default to see what's changed. This is the new code block:

/**
* Junction Deviation Factor
*
* See:
* https://reprap.org/forum/read.php?1,739819
* http://blog.kyneticcnc.com/2018/10/computing-junction-deviation-for-marlin.html
*/
#if DISABLED(CLASSIC_JERK)
#define JUNCTION_DEVIATION_MM 0.013 // (mm) Distance from real junction edge
#endif

@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants