Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we have the Sanity Checks set too tightly for Auto Bed Leveling? #3165

Closed
Roxy-3D opened this issue Mar 16, 2016 · 3 comments
Closed

Do we have the Sanity Checks set too tightly for Auto Bed Leveling? #3165

Roxy-3D opened this issue Mar 16, 2016 · 3 comments

Comments

@Roxy-3D
Copy link
Member

Roxy-3D commented Mar 16, 2016

Please pull up:

http://3dprintboard.com/showthread.php?20871-Question-about-AUTO_BED_LEVELING_GRID_POINTS&p=83412#post83412

I'm wondering if we should relax this check a little bit:

#if X_PROBE_OFFSET_FROM_EXTRUDER < 0 #if (-(X_PROBE_OFFSET_FROM_EXTRUDER * AUTO_BED_LEVELING_GRID_POINTS) >= (RIGHT_PROBE_BED_POSITION - LEFT_PROBE_BED_POSITION))
#error "The X axis probing range is not enough to fit all the points defined in AUTO_BED_LEVELING_GRID_POINTS"
#endif
@Blue-Marlin
Copy link
Contributor

"/Configuration.h:457:8: error: #error "The X axis probing range is not enough to fit all the points defined in AUTO_BED_LEVELING_GRID_POINTS".

That's not code from a current Marlin.
I think the complete check has been dropped.

This is replaced by a runtime check. Search for MIN_PROBE_EDGE in Marlin_Main.cpp.
Even that restriction does not make much sense to me. (hidden limit to restrict AUTO_BED_LEVELING_GRID_POINTS ? Limit number of mesh points, to not subdivide moves too often?)

@Roxy-3D
Copy link
Member Author

Roxy-3D commented Mar 16, 2016

That's not code from a current Marlin. I think the complete check has been dropped.

Oooops! I guess I should have checked before I made a 'New Issue'. Sorry about that!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants